Implement feature int_lowest_highest_one for integer and NonZero types by Gnurou · Pull Request #145381 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Tracking issue: #145203
Implement the accepted ACP #145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.
Also add unit tests for all these types.
r? @jhpratt
rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
This comment has been minimized.
Urk, I overlook something with the NonZero tests... Please hold on a bit until I fix the failures. 🙇
You can use @rustbot author to set it to incomplete status. When ready, you can use @rustbot ready to set it to pending review.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Reminder, once the PR becomes ready for a review, use @rustbot ready.
Implement the accepted ACP for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.
Also add unit tests for all these types.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 73d3d28 has been approved by jhpratt
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
…hpratt
Implement feature int_lowest_highest_one for integer and NonZero types
Tracking issue: rust-lang#145203
Implement the accepted ACP rust-lang#145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.
Also add unit tests for all these types.
jhpratt added a commit to jhpratt/rust that referenced this pull request
…hpratt
Implement feature int_lowest_highest_one for integer and NonZero types
Tracking issue: rust-lang#145203
Implement the accepted ACP rust-lang#145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.
Also add unit tests for all these types.
This was referenced
Aug 19, 2025
bors added a commit that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- #139357 (Fix parameter order for
_by()variants ofmin/max/minmaxinstd::cmp) - #140314 (Rustdoc: typecheck scrape-examples.js)
- #140794 (mention lint group in default level lint note)
- #145006 (Clarify EOF handling for
BufRead::skip_until) - #145252 (Demote x86_64-apple-darwin to Tier 2 with host tools)
- #145359 (Fix bug where
rustdoc-jstester would not pick the rightsearch.jsfile if there is more than one) - #145381 (Implement feature
int_lowest_highest_onefor integer and NonZero types) - #145417 (std_detect: RISC-V platform guide documentation)
- #145531 (Add runtime detection for APX-F and AVX10)
- #145619 (
std_detect: Userustc-std-workspace-*to pull incompiler-builtins) - #145622 (Remove the std workspace patch for
compiler-builtins) - #145623 (Pretty print the name of an future from calling async closure)
- #145626 (add a fallback implementation for the
prefetch_*intrinsics )
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #145381 - Gnurou:int_lowest_highest_one, r=jhpratt
Implement feature int_lowest_highest_one for integer and NonZero types
Tracking issue: #145203
Implement the accepted ACP #145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.
Also add unit tests for all these types.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…hpratt
Implement feature int_lowest_highest_one for integer and NonZero types
Tracking issue: rust-lang#145203
Implement the accepted ACP rust-lang#145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.
Also add unit tests for all these types.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.