tests: Split dont-shuffle-bswaps along opt-levels and arches by workingjubilee · Pull Request #142176 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits2 Checks9 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Fixes #142068

r? @nikic

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 7, 2025

This comment has been minimized.

// CHECK-NEXT: getelementptr inbounds{{( nuw)?}} i8, {{.+}} 12
// CHECK-NEXT: store i16
// CHECK-NEXT: getelementptr inbounds{{( nuw)?}} i8, {{.+}} 14
// CHECK-NEXT: store i16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previously only had the CHECK-NOT: shufflevector. I don't think we actually want to insist that -Copt-level=2 never vectorizes this code?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, well! I believe this was the version of the test that you committed, but I am happy to apply Nikita's disagreements with Nikita :^)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit resolved.

@@ -0,0 +1,32 @@
//@ revisions: OPT2
//@[OPT2] compile-flags: -Copt-level=2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need a revision here anymore, as there's just one now...

📌 Commit c7fd742 has been approved by nikic

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 10, 2025

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 10, 2025

…-per-arch, r=nikic

tests: Split dont-shuffle-bswaps along opt-levels and arches

bors added a commit that referenced this pull request

Jun 10, 2025

Rollup of 13 pull requests

Successful merges:

#134442 (Specify the behavior of file!)
#134841 (Look at proc-macro attributes when encountering unknown attribute)
#140372 (Exhaustively handle parsed attributes in CheckAttr)
#140766 (Stabilize keylocker)
#141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
#142042 (Make E0621 missing lifetime suggestion verbose)
#142101 (core::ptr: deduplicate more method docs)
#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
#142258 (platform-support.md: Mention specific Linux kernel version or later)
#142260 (Miri subtree update)
#142262 (Mark core::slice::memchr as #[doc(hidden)])
#142272 (tests: Change ABIs in tests to more future-resilient ones)
#142275 (rustdoc: Refractor clean_ty_generics)

r? @ghost @rustbot modify labels: rollup

Some architectures gain target-cpu minimums in doing so.

...sigh. I had somehow left in a revision that I thought I removed.

@bors r=nikic

📌 Commit 6b0deb2 has been approved by nikic

It is now in the queue for this repository.

fmease added a commit to fmease/rust that referenced this pull request

Jun 10, 2025

…-per-arch, r=nikic

tests: Split dont-shuffle-bswaps along opt-levels and arches

bors added a commit that referenced this pull request

Jun 11, 2025

Rollup of 13 pull requests

Successful merges:

#128425 (Make missing_fragment_specifier an unconditional error)
#141639 (Expose discriminant values in stable_mir)
#141967 (Configure bootstrap backport nominations through triagebot)
#142042 (Make E0621 missing lifetime suggestion verbose)
#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
#142235 (Build rustc with assertions in dist-alt jobs)
#142248 (Add supported asm types for LoongArch32)
#142272 (tests: Change ABIs in tests to more future-resilient ones)
#142282 (Only run citool tests on the auto branch)
#142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
#142297 (Implement //@ needs-target-std compiletest directive)
#142298 (Make loongarch-none target maintainers more easily pingable)
#142306 (Dont unwrap and re-wrap typing envs)

Failed merges:

#141942 (Implement representation options to smir)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 11, 2025

…-per-arch, r=nikic

tests: Split dont-shuffle-bswaps along opt-levels and arches

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 11, 2025

…-per-arch, r=nikic

tests: Split dont-shuffle-bswaps along opt-levels and arches

bors added a commit that referenced this pull request

Jun 11, 2025

Rollup of 13 pull requests

Successful merges:

#134841 (Look at proc-macro attributes when encountering unknown attribute)
#141639 (Expose discriminant values in stable_mir)
#141967 (Configure bootstrap backport nominations through triagebot)
#142042 (Make E0621 missing lifetime suggestion verbose)
#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
#142248 (Add supported asm types for LoongArch32)
#142272 (tests: Change ABIs in tests to more future-resilient ones)
#142282 (Only run citool tests on the auto branch)
#142297 (Implement //@ needs-target-std compiletest directive)
#142298 (Make loongarch-none target maintainers more easily pingable)
#142306 (Dont unwrap and re-wrap typing envs)
#142324 (Remove unneeded FunctionCx from some codegen methods)
#142328 (feat: Add bit_width for unsigned integer types)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 12, 2025

…-per-arch, r=nikic

tests: Split dont-shuffle-bswaps along opt-levels and arches

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 12, 2025

…-per-arch, r=nikic

tests: Split dont-shuffle-bswaps along opt-levels and arches

bors added a commit that referenced this pull request

Jun 13, 2025

Rollup of 9 pull requests

Successful merges:

#128425 (Make missing_fragment_specifier an unconditional error)
#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
#140770 (add extern "custom" functions)
#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
#142248 (Add supported asm types for LoongArch32)
#142267 (assert more in release in rustc_ast_lowering)
#142274 (Update the stdarch submodule)
#142276 (Update dependencies in library/Cargo.lock)
#142308 (Upgrade object, addr2line, and unwinding in the standard library)

Failed merges:

#140920 (Extract some shared code from codegen backend target feature handling)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

bors added a commit that referenced this pull request

Jun 13, 2025

Rollup of 9 pull requests

Successful merges:

#128425 (Make missing_fragment_specifier an unconditional error)
#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
#140770 (add extern "custom" functions)
#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
#142248 (Add supported asm types for LoongArch32)
#142267 (assert more in release in rustc_ast_lowering)
#142274 (Update the stdarch submodule)
#142276 (Update dependencies in library/Cargo.lock)
#142308 (Upgrade object, addr2line, and unwinding in the standard library)

Failed merges:

#140920 (Extract some shared code from codegen backend target feature handling)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

rust-timer added a commit that referenced this pull request

Jun 13, 2025

Rollup merge of #142176 - workingjubilee:dont-shuffle-bswaps-per-arch, r=nikic

tests: Split dont-shuffle-bswaps along opt-levels and arches

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Jun 14, 2025

bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request

Jun 14, 2025

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Jun 16, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jun 18, 2025

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#128425 (Make missing_fragment_specifier an unconditional error)
rust-lang#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
rust-lang#140770 (add extern "custom" functions)
rust-lang#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
rust-lang#142248 (Add supported asm types for LoongArch32)
rust-lang#142267 (assert more in release in rustc_ast_lowering)
rust-lang#142274 (Update the stdarch submodule)
rust-lang#142276 (Update dependencies in library/Cargo.lock)
rust-lang#142308 (Upgrade object, addr2line, and unwinding in the standard library)

Failed merges:

rust-lang#140920 (Extract some shared code from codegen backend target feature handling)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

antoyo pushed a commit to rust-lang/rustc_codegen_gcc that referenced this pull request

Jun 28, 2025

Labels

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.