tests: Change ABIs in tests to more future-resilient ones by workingjubilee · Pull Request #142272 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits2 Checks9 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

Lets the test still work on different architectures.

We move the vectorcall ABI tests into their own file which is now only run on x86-64, while replacing them with rust-cold ABI tests so that aarch64 hosts continue to test an unstable ABI.

A better solution might be cross-compiling or something but I really don't have time for that right now.

rustbot added A-rustdoc-json

Area: Rustdoc JSON backend

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Jun 9, 2025

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

• It's intentional.
• The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

📌 Commit 518eb0d has been approved by aDotInTheVoid

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 9, 2025

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 10, 2025

…ts, r=aDotInTheVoid

tests: Change ABIs in tests to more future-resilient ones

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

bors added a commit that referenced this pull request

Jun 10, 2025

Rollup of 13 pull requests

Successful merges:

• #134442 (Specify the behavior of file!)
• #134841 (Look at proc-macro attributes when encountering unknown attribute)
• #140372 (Exhaustively handle parsed attributes in CheckAttr)
• #140766 (Stabilize keylocker)
• #141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
• #142042 (Make E0621 missing lifetime suggestion verbose)
• #142101 (core::ptr: deduplicate more method docs)
• #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
• #142258 (platform-support.md: Mention specific Linux kernel version or later)
• #142260 (Miri subtree update)
• #142262 (Mark core::slice::memchr as #[doc(hidden)])
• #142272 (tests: Change ABIs in tests to more future-resilient ones)
• #142275 (rustdoc: Refractor clean_ty_generics)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 10, 2025

…ts, r=aDotInTheVoid

tests: Change ABIs in tests to more future-resilient ones

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

bors added a commit that referenced this pull request

Jun 10, 2025

Rollup of 12 pull requests

Successful merges:

• #134442 (Specify the behavior of file!)
• #134841 (Look at proc-macro attributes when encountering unknown attribute)
• #140372 (Exhaustively handle parsed attributes in CheckAttr)
• #140766 (Stabilize keylocker)
• #141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
• #142042 (Make E0621 missing lifetime suggestion verbose)
• #142101 (core::ptr: deduplicate more method docs)
• #142258 (platform-support.md: Mention specific Linux kernel version or later)
• #142260 (Miri subtree update)
• #142262 (Mark core::slice::memchr as #[doc(hidden)])
• #142272 (tests: Change ABIs in tests to more future-resilient ones)
• #142275 (rustdoc: Refractor clean_ty_generics)

r? @ghost @rustbot modify labels: rollup

fmease added a commit to fmease/rust that referenced this pull request

Jun 10, 2025

…ts, r=aDotInTheVoid

tests: Change ABIs in tests to more future-resilient ones

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

bors added a commit that referenced this pull request

Jun 11, 2025

Rollup of 13 pull requests

Successful merges:

• #128425 (Make missing_fragment_specifier an unconditional error)
• #141639 (Expose discriminant values in stable_mir)
• #141967 (Configure bootstrap backport nominations through triagebot)
• #142042 (Make E0621 missing lifetime suggestion verbose)
• #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
• #142235 (Build rustc with assertions in dist-alt jobs)
• #142248 (Add supported asm types for LoongArch32)
• #142272 (tests: Change ABIs in tests to more future-resilient ones)
• #142282 (Only run citool tests on the auto branch)
• #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
• #142297 (Implement //@ needs-target-std compiletest directive)
• #142298 (Make loongarch-none target maintainers more easily pingable)
• #142306 (Dont unwrap and re-wrap typing envs)

Failed merges:

• #141942 (Implement representation options to smir)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 11, 2025

…ts, r=aDotInTheVoid

tests: Change ABIs in tests to more future-resilient ones

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 11, 2025

…ts, r=aDotInTheVoid

tests: Change ABIs in tests to more future-resilient ones

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

bors added a commit that referenced this pull request

Jun 11, 2025

Rollup of 13 pull requests

Successful merges:

• #134841 (Look at proc-macro attributes when encountering unknown attribute)
• #141639 (Expose discriminant values in stable_mir)
• #141967 (Configure bootstrap backport nominations through triagebot)
• #142042 (Make E0621 missing lifetime suggestion verbose)
• #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
• #142248 (Add supported asm types for LoongArch32)
• #142272 (tests: Change ABIs in tests to more future-resilient ones)
• #142282 (Only run citool tests on the auto branch)
• #142297 (Implement //@ needs-target-std compiletest directive)
• #142298 (Make loongarch-none target maintainers more easily pingable)
• #142306 (Dont unwrap and re-wrap typing envs)
• #142324 (Remove unneeded FunctionCx from some codegen methods)
• #142328 (feat: Add bit_width for unsigned integer types)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 11, 2025

…ts, r=aDotInTheVoid

tests: Change ABIs in tests to more future-resilient ones

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

This was referenced

Jun 11, 2025

bors added a commit that referenced this pull request

Jun 11, 2025

Rollup of 9 pull requests

Successful merges:

• #141967 (Configure bootstrap backport nominations through triagebot)
• #142042 (Make E0621 missing lifetime suggestion verbose)
• #142272 (tests: Change ABIs in tests to more future-resilient ones)
• #142282 (Only run citool tests on the auto branch)
• #142297 (Implement //@ needs-target-std compiletest directive)
• #142298 (Make loongarch-none target maintainers more easily pingable)
• #142306 (Dont unwrap and re-wrap typing envs)
• #142324 (Remove unneeded FunctionCx from some codegen methods)
• #142328 (feat: Add bit_width for unsigned integer types)

Failed merges:

• #141639 (Expose discriminant values in stable_mir)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 11, 2025

Rollup merge of #142272 - workingjubilee:change-some-abi-tests, r=aDotInTheVoid

tests: Change ABIs in tests to more future-resilient ones

Eventually we're going to make these tests not work as they are currently written on HEAD, so change them now to get ahead of that.

r? aDotInTheVoid

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Jun 12, 2025

Labels

A-rustdoc-json

Area: Rustdoc JSON backend

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.