`tests/ui`: A New Order [9/N] by Kivooeo · Pull Request #142214 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

This comment has been minimized.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit, please squash after and I'll r+

//! This test ensures that Rust's allocator maintains the invariant that
//! Box is always non-null, even for zero-sized types and empty allocations.
//! This is crucial for memory safety guarantees in Rust.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this guarantee is overly strong for what this test actually does, it's more like

Check that the default global Rust allocator in combination with Box produces a non-null allocation even when the contained type is zero-sized.

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

⚠️ Warning ⚠️

This PR is based on an upstream commit that is 20 days old.
It's recommended to update your branch according to the rustc-dev-guide.

This comment has been minimized.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

📌 Commit f4502b8 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

bors added a commit that referenced this pull request

Rollup of 4 pull requests

Successful merges:

#142078 (Add SIMD funnel shift and round-to-even intrinsics)
#142214 (tests/ui: A New Order [9/N])
#142417 (tests/ui: A New Order [12/N])
#143030 (Fix suggestion spans inside macros for the unused_must_use lint)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Rollup merge of #142214 - Kivooeo:tf9, r=jieyouxu

tests/ui: A New Order [9/N]

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

RalfJung pushed a commit to RalfJung/miri that referenced this pull request

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Relevant to the compiler team, which will review and decide on the PR/issue.