Fix suggestion spans inside macros for the unused_must_use lint by Urgau · Pull Request #143030 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits2 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This PR fixes the suggestion spans inside macros for the unused_must_use lint by trying to find the oldest ancestor span.
Fixes #143025
r? @SparrowLii
rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
📌 Commit 3175fb2 has been approved by SparrowLii
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Fix suggestion spans inside macros for the unused_must_use lint
This PR fixes the suggestion spans inside macros for the unused_must_use lint by trying to find the oldest ancestor span.
Fixes rust-lang#143025
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #124595 (Suggest cloning
Arcmoved into closure) - #139594 (Simplify
ObligationCauseCode::IfExpression) - #141311 (make
tidy-alphabeticaluse a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
- #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
- #142393 (Don't give APITs names with macro expansion placeholder fragments in it)
- #142884 (StableMIR: Add method to retrieve body of coroutine)
- #142981 (Make missing lifetime suggestion verbose)
- #143030 (Fix suggestion spans inside macros for the
unused_must_uselint)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request
What does this PR try to resolve?
This PR changes the triggering rustc lint in the
fix_only_once_for_duplicates test from unused_must_use to
forgetting_references, because we are changing in
rust-lang/rust#143030 the interaction between
that lint and macros.
This is required as it blocking the rust PR, rust-lang/rust#143030 (comment).
How to test and review this PR?
Look at the test changes.
📌 Commit 3175fb2 has been approved by SparrowLii
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit that referenced this pull request
Rollup of 4 pull requests
Successful merges:
- #142078 (Add SIMD funnel shift and round-to-even intrinsics)
- #142214 (
tests/ui: A New Order [9/N]) - #142417 (
tests/ui: A New Order [12/N]) - #143030 (Fix suggestion spans inside macros for the
unused_must_uselint)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #143030 - Urgau:issue-143025, r=SparrowLii
Fix suggestion spans inside macros for the unused_must_use lint
This PR fixes the suggestion spans inside macros for the unused_must_use lint by trying to find the oldest ancestor span.
Fixes #143025
RalfJung pushed a commit to RalfJung/miri that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.