Make missing lifetime suggestion verbose by compiler-errors · Pull Request #142981 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I keep seeing this suggestion when working on rustc, and it's annoying that it's inline. Part of #141973. Feel free to close this if there's another PR already doing this.
r? @estebank
📌 Commit 250b5d2 has been approved by estebank
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…ggestion, r=estebank
Make missing lifetime suggestion verbose
I keep seeing this suggestion when working on rustc, and it's annoying that it's inline. Part of rust-lang#141973. Feel free to close this if there's another PR already doing this.
r? @estebank
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #124595 (Suggest cloning
Arcmoved into closure) - #139594 (Simplify
ObligationCauseCode::IfExpression) - #141311 (make
tidy-alphabeticaluse a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
- #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
- #142393 (Don't give APITs names with macro expansion placeholder fragments in it)
- #142884 (StableMIR: Add method to retrieve body of coroutine)
- #142981 (Make missing lifetime suggestion verbose)
- #143030 (Fix suggestion spans inside macros for the
unused_must_uselint)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #124595 (Suggest cloning
Arcmoved into closure) - #139594 (Simplify
ObligationCauseCode::IfExpression) - #141311 (make
tidy-alphabeticaluse a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
- #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
- #142393 (Don't give APITs names with macro expansion placeholder fragments in it)
- #142884 (StableMIR: Add method to retrieve body of coroutine)
- #142981 (Make missing lifetime suggestion verbose)
r? @ghost
@rustbot modify labels: rollup
diagnostic only
@bors rollup
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #124595 (Suggest cloning
Arcmoved into closure) - #139594 (Simplify
ObligationCauseCode::IfExpression) - #141311 (make
tidy-alphabeticaluse a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
- #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
- #142393 (Don't give APITs names with macro expansion placeholder fragments in it)
- #142884 (StableMIR: Add method to retrieve body of coroutine)
- #142981 (Make missing lifetime suggestion verbose)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #142981 - compiler-errors:verbose-missing-suggestion, r=estebank
Make missing lifetime suggestion verbose
I keep seeing this suggestion when working on rustc, and it's annoying that it's inline. Part of #141973. Feel free to close this if there's another PR already doing this.
r? @estebank
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
The Rustc Trait System Refactor Initiative (-Znext-solver)