disable core dumps for panic-uninitialized-zeroed by arielb1 · Pull Request #146335 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

That test causes a large amount of crashes. If a system has a /proc/sys/kernel/core_pattern that uploads core dumps enabled, it will take a long time to complete. Set dumpable to 0 to avoid that.

Before:

$ time ./panic-uninitialized-zeroed

real    0m47.457s
user    0m0.023s
sys     0m0.021s

After:

$ ./panic-uninitialized-zeroed

real    0m0.029s
user    0m0.019s
sys     0m0.010s

That test causes a large amount of crashes. If a system has a /proc/sys/kernel/core_pattern that uploads core dumps enabled, it will take a long time to complete. Set dumpable to 0 to avoid that.

Before:

$ time ./panic-uninitialized-zeroed

real 0m47.457s user 0m0.023s sys 0m0.021s

After: $ ./panic-uninitialized-zeroed

real 0m0.029s user 0m0.019s sys 0m0.010s

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've been setting fs.suid_dumpable=0 and kernel.core_pattern=|/bin/false via sysctl to avoid this. Doing it in the test is much better.

@bors r+ rollup

View changes since this review

@nnethercote bors doesn't seem to acknowledge commands left in "review" comments ☹️

@bors r=nnethercote rollup

📌 Commit ef95c63 has been approved by nnethercote

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 10, 2025

bors added a commit that referenced this pull request

Sep 11, 2025

Rollup of 11 pull requests

Successful merges:

#142315 (core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref)
#146335 (disable core dumps for panic-uninitialized-zeroed)
#146347 (report duplicate symbols added by the driver)
#146370 (Update the LoongArch target documentation)
#146379 (Fix compare_against_sw_vers test)
#146380 (Unify and deduplicate bits conv float tests)
#146415 (s390x: mark soft-float target feature as incompatible)
#146422 (Less greedily parse [const] bounds)
#146424 (Improve core::ops coverage)
#146425 (Improve core::array coverage)
#146428 (Revert assert! desugaring changes (#122661))

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Sep 11, 2025

Rollup of 11 pull requests

Successful merges:

#142315 (core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref)
#146335 (disable core dumps for panic-uninitialized-zeroed)
#146347 (report duplicate symbols added by the driver)
#146370 (Update the LoongArch target documentation)
#146379 (Fix compare_against_sw_vers test)
#146380 (Unify and deduplicate bits conv float tests)
#146415 (s390x: mark soft-float target feature as incompatible)
#146422 (Less greedily parse [const] bounds)
#146424 (Improve core::ops coverage)
#146425 (Improve core::array coverage)
#146428 (Revert assert! desugaring changes (#122661))

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Sep 11, 2025

Rollup merge of #146335 - arielb1:dont-dump-core, r=nnethercote

disable core dumps for panic-uninitialized-zeroed

That test causes a large amount of crashes. If a system has a /proc/sys/kernel/core_pattern that uploads core dumps enabled, it will take a long time to complete. Set dumpable to 0 to avoid that.

Before:

$ time ./panic-uninitialized-zeroed

real    0m47.457s
user    0m0.023s
sys     0m0.021s

After:

$ ./panic-uninitialized-zeroed

real    0m0.029s
user    0m0.019s
sys     0m0.010s

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.