Fix compare_against_sw_vers test by madsmtm · Pull Request #146379 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The saturating_sub doesn't actually perform its intended since the version numbers are signed integers (which I changed in a later revision of #138944).
Fixes the issue described in #138944 (comment).
r? tgross35
Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS)
Issue: A test is flaky/unreliable/spuriously fails
labels
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
📌 Commit 23edc4d has been approved by tgross35
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
… r=tgross35
Fix compare_against_sw_vers test
The saturating_sub doesn't actually perform its intended since the version numbers are signed integers (which I changed in a later revision of rust-lang#138944).
Fixes the issue described in rust-lang#138944 (comment).
r? tgross35
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
… r=tgross35
Fix compare_against_sw_vers test
The saturating_sub doesn't actually perform its intended since the version numbers are signed integers (which I changed in a later revision of rust-lang#138944).
Fixes the issue described in rust-lang#138944 (comment).
r? tgross35
bors added a commit that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- #146311 (Minor symbol comment fixes.)
- #146340 (Strip frontmatter in fewer places)
- #146342 (Improve C-variadic error messages: part 2)
- #146347 (report duplicate symbols added by the driver)
- #146374 (Update
browser-ui-testversion to0.22.2) - #146379 (Fix
compare_against_sw_verstest)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 11 pull requests
Successful merges:
- #142315 (core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref)
- #146335 (disable core dumps for panic-uninitialized-zeroed)
- #146347 (report duplicate symbols added by the driver)
- #146370 (Update the LoongArch target documentation)
- #146379 (Fix
compare_against_sw_verstest) - #146380 (Unify and deduplicate bits conv float tests)
- #146415 (s390x: mark soft-float target feature as incompatible)
- #146422 (Less greedily parse
[const]bounds) - #146424 (Improve
core::opscoverage) - #146425 (Improve
core::arraycoverage) - #146428 (Revert
assert!desugaring changes (#122661))
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 11 pull requests
Successful merges:
- #142315 (core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref)
- #146335 (disable core dumps for panic-uninitialized-zeroed)
- #146347 (report duplicate symbols added by the driver)
- #146370 (Update the LoongArch target documentation)
- #146379 (Fix
compare_against_sw_verstest) - #146380 (Unify and deduplicate bits conv float tests)
- #146415 (s390x: mark soft-float target feature as incompatible)
- #146422 (Less greedily parse
[const]bounds) - #146424 (Improve
core::opscoverage) - #146425 (Improve
core::arraycoverage) - #146428 (Revert
assert!desugaring changes (#122661))
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #146379 - madsmtm:fix-platform_version-test, r=tgross35
Fix compare_against_sw_vers test
The saturating_sub doesn't actually perform its intended since the version numbers are signed integers (which I changed in a later revision of #138944).
Fixes the issue described in #138944 (comment).
r? tgross35
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
… r=tgross35
Fix compare_against_sw_vers test
The saturating_sub doesn't actually perform its intended since the version numbers are signed integers (which I changed in a later revision of rust-lang#138944).
Fixes the issue described in rust-lang#138944 (comment).
r? tgross35
Labels
Issue: A test is flaky/unreliable/spuriously fails
Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS)
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.