Do not suggest moving expression out of for loop when hitting break from desugaring by estebank · Pull Request #149863 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks11 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? @mati865
rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
This comment has been minimized.
r=me with tidy addressed:tidy [style (tests)]: /checkout/tests/ui/moves/arc-consumed-in-looped-closure.rs:27: trailing whitespace
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
📌 Commit c60ed21 has been approved by mati865
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request
Do not suggest moving expression out of for loop when hitting break from desugaring
Fix rust-lang#149861.
bors added a commit that referenced this pull request
…uwer
Rollup of 10 pull requests
Successful merges:
- #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
- #146584 (remove duplicated columns from
rustc_error_code::error_codes!) - #148717 (Point at span within local macros even when error happens in nested external macro)
- #148825 (Add SystemTime::{MIN, MAX})
- #149565 (rustdoc: Add unstable
--merge-doctests=yes/no/autoflag) - #149770 (Rename some issue-* tests)
- #149807 (Use ubuntu:24.04 for the
x86_64-gnu-mirijob) - #149850 (Remove "tidy" tool for
tests/rustdoctestsuite) - #149863 (Do not suggest moving expression out of for loop when hitting
breakfrom desugaring) - #149867 (only resolve main in bin crates)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
- #146584 (remove duplicated columns from
rustc_error_code::error_codes!) - #148717 (Point at span within local macros even when error happens in nested external macro)
- #149565 (rustdoc: Add unstable
--merge-doctests=yes/no/autoflag) - #149770 (Rename some issue-* tests)
- #149807 (Use ubuntu:24.04 for the
x86_64-gnu-mirijob) - #149850 (Remove "tidy" tool for
tests/rustdoctestsuite) - #149863 (Do not suggest moving expression out of for loop when hitting
breakfrom desugaring) - #149867 (only resolve main in bin crates)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
- #146584 (remove duplicated columns from
rustc_error_code::error_codes!) - #148717 (Point at span within local macros even when error happens in nested external macro)
- #149565 (rustdoc: Add unstable
--merge-doctests=yes/no/autoflag) - #149770 (Rename some issue-* tests)
- #149807 (Use ubuntu:24.04 for the
x86_64-gnu-mirijob) - #149850 (Remove "tidy" tool for
tests/rustdoctestsuite) - #149863 (Do not suggest moving expression out of for loop when hitting
breakfrom desugaring) - #149867 (only resolve main in bin crates)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #149863 - estebank:issue-149861, r=mati865
Do not suggest moving expression out of for loop when hitting break from desugaring
Fix #149861.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.