Remove "tidy" tool for tests/rustdoc testsuite by GuillaumeGomez · Pull Request #149850 · rust-lang/rust (original) (raw)
As discussed in the last rustdoc meeting, it seems like the current tidy tool is not used much for the rustdoc testsuite by the rustdoc contributors as it doesn't fit nicely our needs.
Until we find something better, we decided to remove it.
r? @yotamofek
Some changes occurred in src/tools/compiletest
cc @jieyouxu
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This comment has been minimized.
So many deleted lines 🤩
r=me once CI is green
📌 Commit 4d697d2 has been approved by yotamofek
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
bors added a commit that referenced this pull request
Rollup of 4 pull requests
Successful merges:
- #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
- #149807 (Use ubuntu:24.04 for the
x86_64-gnu-mirijob) - #149850 (Remove "tidy" tool for
tests/rustdoctestsuite) - #149867 (only resolve main in bin crates)
r? @ghost
@rustbot modify labels: rollup
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request
bors added a commit that referenced this pull request
…uwer
Rollup of 10 pull requests
Successful merges:
- #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
- #146584 (remove duplicated columns from
rustc_error_code::error_codes!) - #148717 (Point at span within local macros even when error happens in nested external macro)
- #148825 (Add SystemTime::{MIN, MAX})
- #149565 (rustdoc: Add unstable
--merge-doctests=yes/no/autoflag) - #149770 (Rename some issue-* tests)
- #149807 (Use ubuntu:24.04 for the
x86_64-gnu-mirijob) - #149850 (Remove "tidy" tool for
tests/rustdoctestsuite) - #149863 (Do not suggest moving expression out of for loop when hitting
breakfrom desugaring) - #149867 (only resolve main in bin crates)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
- #146584 (remove duplicated columns from
rustc_error_code::error_codes!) - #148717 (Point at span within local macros even when error happens in nested external macro)
- #149565 (rustdoc: Add unstable
--merge-doctests=yes/no/autoflag) - #149770 (Rename some issue-* tests)
- #149807 (Use ubuntu:24.04 for the
x86_64-gnu-mirijob) - #149850 (Remove "tidy" tool for
tests/rustdoctestsuite) - #149863 (Do not suggest moving expression out of for loop when hitting
breakfrom desugaring) - #149867 (only resolve main in bin crates)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
- #146584 (remove duplicated columns from
rustc_error_code::error_codes!) - #148717 (Point at span within local macros even when error happens in nested external macro)
- #149565 (rustdoc: Add unstable
--merge-doctests=yes/no/autoflag) - #149770 (Rename some issue-* tests)
- #149807 (Use ubuntu:24.04 for the
x86_64-gnu-mirijob) - #149850 (Remove "tidy" tool for
tests/rustdoctestsuite) - #149863 (Do not suggest moving expression out of for loop when hitting
breakfrom desugaring) - #149867 (only resolve main in bin crates)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
bootstrap: Don't pass an unused --color to compiletest
- Follow-up to rust-lang#149850
This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.
A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.
jhpratt added a commit to jhpratt/rust that referenced this pull request
bootstrap: Don't pass an unused --color to compiletest
- Follow-up to rust-lang#149850
This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.
A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
jhpratt added a commit to jhpratt/rust that referenced this pull request
bootstrap: Don't pass an unused --color to compiletest
- Follow-up to rust-lang#149850
This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.
A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.
rust-timer added a commit that referenced this pull request
Rollup merge of #149911 - Zalathar:no-color, r=jieyouxu
bootstrap: Don't pass an unused --color to compiletest
- Follow-up to #149850
This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.
A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.