Weak for Arc pointer is marked as DynSend/DynSync by azhogin · Pull Request #149874 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks11 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
std::sync::Weak (weak pointer for Arc) added to DynSend and DynSync (looks like it was missed to add there when implemented).
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? @eholk
rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
📌 Commit 1b790cd has been approved by eholk
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
…sync, r=eholk
Weak for Arc pointer is marked as DynSend/DynSync
std::sync::Weak (weak pointer for Arc) added to DynSend and DynSync (looks like it was missed to add there when implemented).
bors added a commit that referenced this pull request
Rollup of 11 pull requests
Successful merges:
- #145278 (Update
rustc_codegen_gccrotate operation document) - #148825 (Add SystemTime::{MIN, MAX})
- #148837 (Use
let...elseinstead ofmatch foo { ... _ => return };andif let ... else return) - #149177 (Add proper suggestion for associated function with unknown field)
- #149843 (Inherit attributes in delegation)
- #149860 (Fix: Prevent macro-expanded extern crates from shadowing extern arguments)
- #149874 (Weak for Arc pointer is marked as DynSend/DynSync)
- #149903 (Remove unused code in
cfg_old) - #149911 (bootstrap: Don't pass an unused
--colorto compiletest) - #149916 (Add a sanity check in case of any duplicate nodes)
- #149924 (
declare_lint_passforINLINE_ALWAYS_MISMATCHING_TARGET_FEATURES)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- #145278 (Update
rustc_codegen_gccrotate operation document) - #148837 (Use
let...elseinstead ofmatch foo { ... _ => return };andif let ... else return) - #149177 (Add proper suggestion for associated function with unknown field)
- #149843 (Inherit attributes in delegation)
- #149860 (Fix: Prevent macro-expanded extern crates from shadowing extern arguments)
- #149874 (Weak for Arc pointer is marked as DynSend/DynSync)
- #149903 (Remove unused code in
cfg_old) - #149911 (bootstrap: Don't pass an unused
--colorto compiletest) - #149916 (Add a sanity check in case of any duplicate nodes)
- #149924 (
declare_lint_passforINLINE_ALWAYS_MISMATCHING_TARGET_FEATURES)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #149874 - azhogin:azhogin/arc_weak_dyn_send_sync, r=eholk
Weak for Arc pointer is marked as DynSend/DynSync
std::sync::Weak (weak pointer for Arc) added to DynSend and DynSync (looks like it was missed to add there when implemented).
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.