bootstrap: Don't pass an unused --color to compiletest by Zalathar · Pull Request #149911 · rust-lang/rust (original) (raw)

• Follow-up to Remove "tidy" tool for tests/rustdoc testsuite #149850

This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.

A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.

This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.

This logic is cargo-specific anyway, so there is no need for it to be a generally-available helper method.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot added the T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

label

Dec 12, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌 Commit 0e7dc32 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 12, 2025

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Dec 12, 2025

bootstrap: Don't pass an unused --color to compiletest

• Follow-up to rust-lang#149850

This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.

A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.

jhpratt added a commit to jhpratt/rust that referenced this pull request

Dec 13, 2025

bootstrap: Don't pass an unused --color to compiletest

• Follow-up to rust-lang#149850

This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.

A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.

bors added a commit that referenced this pull request

Dec 13, 2025

Rollup of 11 pull requests

Successful merges:

• #145278 (Update rustc_codegen_gcc rotate operation document)
• #148825 (Add SystemTime::{MIN, MAX})
• #148837 (Use let...else instead of match foo { ... _ => return }; and if let ... else return)
• #149177 (Add proper suggestion for associated function with unknown field)
• #149843 (Inherit attributes in delegation)
• #149860 (Fix: Prevent macro-expanded extern crates from shadowing extern arguments)
• #149874 (Weak for Arc pointer is marked as DynSend/DynSync)
• #149903 (Remove unused code in cfg_old)
• #149911 (bootstrap: Don't pass an unused --color to compiletest)
• #149916 (Add a sanity check in case of any duplicate nodes)
• #149924 (declare_lint_pass for INLINE_ALWAYS_MISMATCHING_TARGET_FEATURES)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Dec 13, 2025

Rollup of 10 pull requests

Successful merges:

• #145278 (Update rustc_codegen_gcc rotate operation document)
• #148837 (Use let...else instead of match foo { ... _ => return }; and if let ... else return)
• #149177 (Add proper suggestion for associated function with unknown field)
• #149843 (Inherit attributes in delegation)
• #149860 (Fix: Prevent macro-expanded extern crates from shadowing extern arguments)
• #149874 (Weak for Arc pointer is marked as DynSend/DynSync)
• #149903 (Remove unused code in cfg_old)
• #149911 (bootstrap: Don't pass an unused --color to compiletest)
• #149916 (Add a sanity check in case of any duplicate nodes)
• #149924 (declare_lint_pass for INLINE_ALWAYS_MISMATCHING_TARGET_FEATURES)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Dec 13, 2025

Rollup merge of #149911 - Zalathar:no-color, r=jieyouxu

bootstrap: Don't pass an unused --color to compiletest

• Follow-up to #149850

This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.

A follow-up commit also inlines force_coloring_in_ci into its only remaining caller, and updates its comment.