Turn feature-gate table into a query so it is covered by dependency tracking. by michaelwoerister · Pull Request #48208 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation25 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Turn access to feature gates into a query so we handle them correctly during incremental compilation.
Features are still available via Session through features_untracked(). I wish we had a better way of hiding untracked information. It would be great if we could remove the sess field from TyCtxt.
Fixes #47003.
(rust_highfive has picked a reviewer for you, use r? to override)
Track features Turn feature-gate table into a query so it is covered by dependency tracking.
📌 Commit d691c46 has been approved by petrochenkov
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Manishearth added a commit to Manishearth/rust that referenced this pull request
…petrochenkov
Turn feature-gate table into a query so it is covered by dependency tracking.
Turn access to feature gates into a query so we handle them correctly during incremental compilation.
Features are still available via Session through features_untracked(). I wish we had a better way of hiding untracked information. It would be great if we could remove the sess field from TyCtxt.
Fixes rust-lang#47003.
Manishearth added a commit to Manishearth/rust that referenced this pull request
bors added a commit that referenced this pull request
Rollup of 17 pull requests
- Successful merges: #48052, #48072, #48082, #48083, #48084, #48106, #48123, #48157, #48185, #48197, #48198, #48206, #48208, #48221, #48258, #48314, #48335
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request
…petrochenkov
Turn feature-gate table into a query so it is covered by dependency tracking.
Turn access to feature gates into a query so we handle them correctly during incremental compilation.
Features are still available via Session through features_untracked(). I wish we had a better way of hiding untracked information. It would be great if we could remove the sess field from TyCtxt.
Fixes rust-lang#47003.
bors added a commit that referenced this pull request
Rollup of 15 pull requests
- Successful merges: #47987, #48056, #48061, #48084, #48143, #48185, #48206, #48208, #48232, #48246, #48258, #48317, #48353, #48356, #48402
- Failed merges:
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
☔ The latest upstream changes (presumably #48586) made this pull request unmergeable. Please resolve the merge conflicts.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Rebased.
@bors r=petrochenkov
📌 Commit 93625f1 has been approved by petrochenkov
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit that referenced this pull request
Turn feature-gate table into a query so it is covered by dependency tracking.
Turn access to feature gates into a query so we handle them correctly during incremental compilation.
Features are still available via Session through features_untracked(). I wish we had a better way of hiding untracked information. It would be great if we could remove the sess field from TyCtxt.
Fixes #47003.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
AppVeyor timed out but all dist bots succeeded, merging manually
This was referenced
Mar 5, 2018