Implement implied shortcut links for intra-rustdoc-links by Manishearth · Pull Request #48335 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits5 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This was referenced
Feb 18, 2018
Shouldn't this wait until the referenced PR is merged upstream and set into a release?
Yes, that's why it says "needs X".
I'm putting this up for testing and review 😄
Status: Blocked on something else such as an RFC or other implementation work.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Status: Blocked on something else such as an RFC or other implementation work.
label
Raph did a release, ready to land.
r?
Dang, that came together fast. r=me pending travis
📌 Commit 5fdc10c has been approved by QuietMisdreavus
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Manishearth added a commit to Manishearth/rust that referenced this pull request
Manishearth added a commit to Manishearth/rust that referenced this pull request
bors added a commit that referenced this pull request
Rollup of 17 pull requests
- Successful merges: #48052, #48072, #48082, #48083, #48084, #48106, #48123, #48157, #48185, #48197, #48198, #48206, #48208, #48221, #48258, #48314, #48335
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
bors added a commit that referenced this pull request
Rollup of 12 pull requests
- Successful merges: #47379, #47833, #48106, #48198, #48314, #48325, #48335, #48352, #48354, #48360, #48382, #48397
- Failed merges:
I wonder if this should be tracked for relnotes. It's such a win for well-interlinked documentation that as many people as possible should be aware of it!
Sorry, what I meant is that when this does stabilize, and #43466 is brought up, the feature landed in this PR specifically should be highlighted.
That's supposed to work with this PR, given that the intra-links test verifies that shortcut links with backticks properly resolve. >_>
idk why the test passes, the current implementation doesn't seem to work here (I thought it would but on second thoughts it's missing some things); I need to fix that 😄
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.