Pretty print `$crate` as `crate` or `crate_name` in more cases by petrochenkov · Pull Request #57915 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

So, people do parse output of --pretty=expanded (sigh), so covering only the legacy proc-macro case (like it was done in #57155) is not enough.

This PRs resolves all $crates produced by macros, so they are all printed in the parseable form $crate::foo -> crate::foo or crate_name::foo.

Fixes #38016 (comment)
Fixes #57155 (comment)

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

This was referenced

Jan 26, 2019

📌 Commit c375333 has been approved by zackmdavis

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 28, 2019

Centril added a commit to Centril/rust that referenced this pull request

Jan 28, 2019

Pretty print $crate as crate or crate_name in more cases

So, people do parse output of --pretty=expanded (sigh), so covering only the legacy proc-macro case (like it was done in rust-lang#57155) is not enough.

This PRs resolves all $crates produced by macros, so they are all printed in the parseable form $crate::foo -> crate::foo or crate_name::foo.

Fixes rust-lang#38016 (comment) Fixes rust-lang#57155 (comment)

Centril added a commit to Centril/rust that referenced this pull request

Jan 28, 2019

Pretty print $crate as crate or crate_name in more cases

So, people do parse output of --pretty=expanded (sigh), so covering only the legacy proc-macro case (like it was done in rust-lang#57155) is not enough.

This PRs resolves all $crates produced by macros, so they are all printed in the parseable form $crate::foo -> crate::foo or crate_name::foo.

Fixes rust-lang#38016 (comment) Fixes rust-lang#57155 (comment)

bors added a commit that referenced this pull request

Jan 29, 2019

Rollup of 7 pull requests

Successful merges:

#57045 (Kill remaining uses of mem::uninitialized in libcore, liballoc)
#57674 (Avoid erase_regions_ty queries if there are no regions to erase)
#57833 (Print a slightly clearer message when failing to launch a thread)
#57859 (Fix invalid background color)
#57904 (add typo suggestion to unknown attribute error)
#57915 (Pretty print $crate as crate or crate_name in more cases)
#57950 (Extend E0106, E0261)

Failed merges:

r? @ghost

bors bot added a commit to gfx-rs/wgpu that referenced this pull request

Mar 1, 2019

84: Create buffer mapped r=kvark a=swiftcoder

I haven't really taken a swing at error handling here, posting it up early for feedback on the API.

85: Unpin nightly date for bindings generation r=kvark a=grovesNL

rust-lang/rust#57915 allows us to run bindings generation with nightly again, so we shouldn't have to pin to an older nightly date anymore (assuming everyone has a recent nightly).

Co-authored-by: Tristam MacDonald tristam@trist.am Co-authored-by: Joshua Groves josh@joshgroves.com

Centril added a commit to Centril/rust that referenced this pull request

Jul 10, 2019

…ulacrum

Fix pretty-printing of $crate (take 4)

Pretty-print $crate as crate or crate_name in unstructured tokens like a <math xmlns="http://www.w3.org/1998/Math/MathML"><semantics><mrow><mi>c</mi><mi>r</mi><mi>a</mi><mi>t</mi><mi>e</mi><mi>c</mi><mi mathvariant="normal">‘</mi><mi>i</mi><mi>n</mi><mi mathvariant="normal">‘</mi><mi>f</mi><mi>o</mi><mi>o</mi><mo stretchy="false">!</mo><mo stretchy="false">(</mo><mi>a</mi></mrow><annotation encoding="application/x-tex">crate c in foo!(a </annotation></semantics></math>cratec‘in‘foo!(acrate c), but only if those tokens are printed as a part of AST pretty-printing, rather than as a standalone token stream.

Fixes rust-lang#62325 Previous iterations - rust-lang#56647, rust-lang#57155, rust-lang#57915.

kvark pushed a commit to gfx-rs/wgpu-native that referenced this pull request

Apr 17, 2020

84: Create buffer mapped r=kvark a=swiftcoder

I haven't really taken a swing at error handling here, posting it up early for feedback on the API.

85: Unpin nightly date for bindings generation r=kvark a=grovesNL

rust-lang/rust#57915 allows us to run bindings generation with nightly again, so we shouldn't have to pin to an older nightly date anymore (assuming everyone has a recent nightly).

Co-authored-by: Tristam MacDonald tristam@trist.am Co-authored-by: Joshua Groves josh@joshgroves.com

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Pretty print $crate as crate or crate_name in more cases by petrochenkov · Pull Request #57915 · rust-lang/rust (original) (raw)

Conversation

Pretty print `$crate` as `crate` or `crate_name` in more cases by petrochenkov · Pull Request #57915 · rust-lang/rust (original) (raw)