Extend E0106, E0261 by QuietMisdreavus · Pull Request #57950 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is a reopening of #57310 with review comments addressed because the original author has since deleted their fork.
From the author (@purple-ice):
Added an example that points out hardly obvious mistake one could make when writing impl for a new type.
r? @rust-lang/docs
Added an example that points out hardly obvious mistake one could make when writing impl for a new type.
Replaced impl block dock with suggested one and made sure that blocks compile.
r=me after travis is happy
📌 Commit a2b75ed has been approved by estebank
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Centril added a commit to Centril/rust that referenced this pull request
…r=estebank
Extend E0106, E0261
This is a reopening of rust-lang#57310 with review comments addressed because the original author has since deleted their fork.
From the author (@purple-ice):
Added an example that points out hardly obvious mistake one could make when writing impl for a new type.
r? @rust-lang/docs
bors added a commit that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- #57045 (Kill remaining uses of mem::uninitialized in libcore, liballoc)
- #57674 (Avoid erase_regions_ty queries if there are no regions to erase)
- #57833 (Print a slightly clearer message when failing to launch a thread)
- #57859 (Fix invalid background color)
- #57904 (add typo suggestion to unknown attribute error)
- #57915 (Pretty print
$crateascrateorcrate_namein more cases) - #57950 (Extend E0106, E0261)
Failed merges:
r? @ghost
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.