rustdoc: mask compiler_builtins docs by euclio · Pull Request #58448 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #46783.
I wasn't able to fully confirm the underlying cause, but my theory is that functions in compiler_builtins were overwriting functions with the same names in libcore in the search index. Since the functions in compiler_builtins didn't have docs, that's why they weren't appearing in the results.
Masking the compiler_builtins crate fixes the search results. It appears that this crate was accidentally unmasked in #49503.
Since compiler_builtins is being injected automatically, its docs
aren't masked. This commit masks the crate's docs if it's brought in as
an extern crate.
(rust_highfive has picked a reviewer for you, use r? to override)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks!
📌 Commit f565efd has been approved by QuietMisdreavus
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Centril added a commit to Centril/rust that referenced this pull request
…sdreavus
rustdoc: mask compiler_builtins docs
Fixes rust-lang#46783.
I wasn't able to fully confirm the underlying cause, but my theory is that functions in compiler_builtins were overwriting functions with the same names in libcore in the search index. Since the functions in compiler_builtins didn't have docs, that's why they weren't appearing in the results.
Masking the compiler_builtins crate fixes the search results. It appears that this crate was accidentally unmasked in rust-lang#49503.
kennytm added a commit to kennytm/rust that referenced this pull request
…sdreavus
rustdoc: mask compiler_builtins docs
Fixes rust-lang#46783.
I wasn't able to fully confirm the underlying cause, but my theory is that functions in compiler_builtins were overwriting functions with the same names in libcore in the search index. Since the functions in compiler_builtins didn't have docs, that's why they weren't appearing in the results.
Masking the compiler_builtins crate fixes the search results. It appears that this crate was accidentally unmasked in rust-lang#49503.
bors added a commit that referenced this pull request
Rollup of 19 pull requests
Successful merges:
- #57929 (Rustdoc remove old style files)
- #57981 (Fix #57730)
- #58074 (Stabilize slice_sort_by_cached_key)
- #58196 (Add specific feature gate error for const-unstable features)
- #58293 (Remove code for updating copyright years in generate-deriving-span-tests)
- #58306 (Don't default on std crate when manipulating browser history)
- #58359 (librustc_mir: use ? in impl_snapshot_for! macro)
- #58395 (Instant::checked_duration_since)
- #58429 (fix Box::into_unique effecitvely transmuting to a raw ptr)
- #58433 (Update which libcore/liballoc tests Miri ignores, and document why)
- #58438 (Use posix_spawn_file_actions_addchdir_np when possible)
- #58440 (Whitelist the ARM v6 target-feature)
- #58448 (rustdoc: mask
compiler_builtinsdocs) - #58468 (split MaybeUninit into several features, expand docs a bit)
- #58477 (Fix the syntax error in publish_toolstate.py)
- #58479 (compile-pass test for #53606)
- #58489 (Fix runtime error in generate-keyword-tests)
- #58496 (Fix documentation for std::path::PathBuf::pop)
- #58509 (Notify myself when Clippy toolstate changes)
bors added a commit that referenced this pull request
Rollup of 19 pull requests
Successful merges:
- #57929 (Rustdoc remove old style files)
- #57981 (Fix #57730)
- #58074 (Stabilize slice_sort_by_cached_key)
- #58196 (Add specific feature gate error for const-unstable features)
- #58293 (Remove code for updating copyright years in generate-deriving-span-tests)
- #58306 (Don't default on std crate when manipulating browser history)
- #58359 (librustc_mir: use ? in impl_snapshot_for! macro)
- #58395 (Instant::checked_duration_since)
- #58429 (fix Box::into_unique effecitvely transmuting to a raw ptr)
- #58433 (Update which libcore/liballoc tests Miri ignores, and document why)
- #58438 (Use posix_spawn_file_actions_addchdir_np when possible)
- #58440 (Whitelist the ARM v6 target-feature)
- #58448 (rustdoc: mask
compiler_builtinsdocs) - #58468 (split MaybeUninit into several features, expand docs a bit)
- #58479 (compile-pass test for #53606)
- #58489 (Fix runtime error in generate-keyword-tests)
- #58496 (Fix documentation for std::path::PathBuf::pop)
- #58509 (Notify myself when Clippy toolstate changes)
- #58521 (Fix tracking issue for error iterators)
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.