split MaybeUninit into several features, expand docs a bit by RalfJung · Pull Request #58468 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This splits the maybe_uninit feature gate into several:

maybe_uninit for what we will hopefully stabilize soon-ish.
maybe_uninit_ref for creating references into MaybeUninit, for which the rules are not yet clear.
maybe_uninit_slice for handling slices of MaybeUninit, which needs more API design work.
maybe_uninit_array for creating arrays of MaybeUninit using a macro (because we don't have Tracking issue for RFC 2203, "Constants in array repeat expressions" #49147 yet).

Is that an okay thing to do? The goal is to help people avoid APIs we do not want to stabilize yet. I used this to make sure rustc itself does not use get_ref and get_mut.

I also extended the docs to advise against uninitialized integers -- again this is something for which the rules are still being discussed.

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; seems like a good partition except for one thing.

r? @Centril

I think this is a good step allowing us to do incremental progress in a reasonable way...

...As such, r=me with green travis.

If team members disagree with this incremental approach, feel free to r-.

📌 Commit 95ef9b4 has been approved by Centril

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 15, 2019

kennytm added a commit to kennytm/rust that referenced this pull request

Feb 16, 2019

split MaybeUninit into several features, expand docs a bit

This splits the maybe_uninit feature gate into several:

maybe_uninit for what we will hopefully stabilize soon-ish.
maybe_uninit_ref for creating references into MaybeUninit, for which the rules are not yet clear.
maybe_uninit_slice for handling slices of MaybeUninit, which needs more API design work.
maybe_uninit_array for creating arrays of MaybeUninit using a macro (because we don't have rust-lang#49147 yet).

Is that an okay thing to do? The goal is to help people avoid APIs we do not want to stabilize yet. I used this to make sure rustc itself does not use get_ref and get_mut.

I also extended the docs to advise against uninitialized integers -- again this is something for which the rules are still being discussed.

bors added a commit that referenced this pull request

Feb 16, 2019

Rollup of 19 pull requests

Successful merges:

#57929 (Rustdoc remove old style files)
#57981 (Fix #57730)
#58074 (Stabilize slice_sort_by_cached_key)
#58196 (Add specific feature gate error for const-unstable features)
#58293 (Remove code for updating copyright years in generate-deriving-span-tests)
#58306 (Don't default on std crate when manipulating browser history)
#58359 (librustc_mir: use ? in impl_snapshot_for! macro)
#58395 (Instant::checked_duration_since)
#58429 (fix Box::into_unique effecitvely transmuting to a raw ptr)
#58433 (Update which libcore/liballoc tests Miri ignores, and document why)
#58438 (Use posix_spawn_file_actions_addchdir_np when possible)
#58440 (Whitelist the ARM v6 target-feature)
#58448 (rustdoc: mask compiler_builtins docs)
#58468 (split MaybeUninit into several features, expand docs a bit)
#58477 (Fix the syntax error in publish_toolstate.py)
#58479 (compile-pass test for #53606)
#58489 (Fix runtime error in generate-keyword-tests)
#58496 (Fix documentation for std::path::PathBuf::pop)
#58509 (Notify myself when Clippy toolstate changes)

bors added a commit that referenced this pull request

Feb 17, 2019

Rollup of 19 pull requests

Successful merges:

#57929 (Rustdoc remove old style files)
#57981 (Fix #57730)
#58074 (Stabilize slice_sort_by_cached_key)
#58196 (Add specific feature gate error for const-unstable features)
#58293 (Remove code for updating copyright years in generate-deriving-span-tests)
#58306 (Don't default on std crate when manipulating browser history)
#58359 (librustc_mir: use ? in impl_snapshot_for! macro)
#58395 (Instant::checked_duration_since)
#58429 (fix Box::into_unique effecitvely transmuting to a raw ptr)
#58433 (Update which libcore/liballoc tests Miri ignores, and document why)
#58438 (Use posix_spawn_file_actions_addchdir_np when possible)
#58440 (Whitelist the ARM v6 target-feature)
#58448 (rustdoc: mask compiler_builtins docs)
#58468 (split MaybeUninit into several features, expand docs a bit)
#58479 (compile-pass test for #53606)
#58489 (Fix runtime error in generate-keyword-tests)
#58496 (Fix documentation for std::path::PathBuf::pop)
#58509 (Notify myself when Clippy toolstate changes)
#58521 (Fix tracking issue for error iterators)

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.