Remove unneeded calls to format!() by dotdash · Pull Request #69541 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @estebank
(rust_highfive has picked a reviewer for you, use r? to override)
📌 Commit c1de0b1 has been approved by Mark-Simulacrum
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Out of interest, how were these found? Clippy?
I wish it was ;-)
Some time in 2018 I added a hack to format!() to find unnecessary calls, but forgot to submit the results. Recently I rediscovered that branch, but rebasing failed, and lots of cases had already been fixed. Since the old approach was slow, I resorted to some creative use of ripgrep that left me with a few dozen places I manually checked when I was stumped by a completely unrelated problem and needed some brainless activity to clear my mind.
bors added a commit that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- #68989 (Update RELEASES.md for 1.42.0)
- #69340 (instantiate_value_path: on
SelfCtor, avoid unconstrained tyvars) - #69384 (parser:
token->normalized_token,nonnormalized_token->token) - #69452 (typeck: use
Patternobligation cause more for better diagnostics) - #69481 (use char instead of &str for single char patterns)
- #69522 (error_derive_forbidden_on_non_adt: be more graceful)
- #69538 (Stabilize
boxed_slice_try_from) - #69539 (late resolve, visit_fn: bail early if there's no body.)
- #69541 (Remove unneeded calls to format!())
- #69547 (remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls.)
Failed merges:
r? @ghost
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
use .to_string() instead of format!() macro to create strings
handles what is left after rust-lang#69541
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.