Allow multiple asm! options groups and report an error on duplicate options by camelid · Pull Request #73227 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

camelid changed the titleAllow multiple asm! options Allow multiple asm! options and error on duplicate options

Jun 15, 2020

camelid marked this pull request as ready for review

June 15, 2020 19:24

Comment on lines 278 to 285

camelid changed the titleAllow multiple asm! options and error on duplicate options Allow multiple asm! options groups and report an error on duplicate options

Jun 20, 2020

For some reason, the help message is now in a separate message, which adds a lot of noise. I would like to try to get it back to one message.

That way the comma isn't highlighted as part of the option in the UI.

Weirdly, the comma removal suggestion shows up in the UI.

The UI isn't glitching anymore.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 20, 2020

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2020

…arth

Rollup of 9 pull requests

Successful merges:

• rust-lang#72456 (Try to suggest dereferences on trait selection failed)
• rust-lang#72788 (Projection bound validation)
• rust-lang#72790 (core/time: Add Duration methods for zero)
• rust-lang#73227 (Allow multiple asm! options groups and report an error on duplicate options)
• rust-lang#73287 (lint: normalize projections using opaque types)
• rust-lang#73291 (Pre-compute LocalDefId <-> HirId mappings and remove NodeId <-> HirId conversion APIs)
• rust-lang#73378 (Remove use of specialization from librustc_arena)
• rust-lang#73411 (Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15))
• rust-lang#73443 (ci: allow gating GHA on everything but macOS)

Failed merges:

r? @ghost

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 10, 2021

Fix ABNF of inline asm options

This is the case since rust-lang#73227.

r? @camelid