lint: normalize projections using opaque types by davidtwco · Pull Request #73287 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
r? @estebank
(rust_highfive has picked a reviewer for you, use r? to override)
This was referenced
Jun 12, 2020
Needs ./x.py fmt.
r=me after that
Oops, fixed, will r=you after CI passes.
This comment has been minimized.
Pushed a minor commit re-wording to re-trigger CI as the last failure was spurious.
📌 Commit 4ff1678 has been approved by estebank
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixes rust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixes rust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixes rust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 792bd3b has been approved by estebank
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Manishearth added a commit to Manishearth/rust that referenced this pull request
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixes rust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
This commit normalizes projections which contain opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this commit fail).
Signed-off-by: David Wood david@davidtw.co
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 2e781dd has been approved by estebank
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Manishearth added a commit to Manishearth/rust that referenced this pull request
…in-projections, r=estebank
lint: normalize projections using opaque types
Fixes rust-lang#73251.
This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
This was referenced
Jun 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request
…arth
Rollup of 9 pull requests
Successful merges:
- rust-lang#72456 (Try to suggest dereferences on trait selection failed)
- rust-lang#72788 (Projection bound validation)
- rust-lang#72790 (core/time: Add Duration methods for zero)
- rust-lang#73227 (Allow multiple
asm!options groups and report an error on duplicate options) - rust-lang#73287 (lint: normalize projections using opaque types)
- rust-lang#73291 (Pre-compute
LocalDefId<->HirIdmappings and removeNodeId<->HirIdconversion APIs) - rust-lang#73378 (Remove use of specialization from librustc_arena)
- rust-lang#73411 (Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15))
- rust-lang#73443 (ci: allow gating GHA on everything but macOS)
Failed merges:
r? @ghost
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.