Stabilize -Z print-link-args as --print link-args by joshtriplett · Pull Request #91606 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

We have stable options for adding linker arguments; we should have a
stable option to help debug linker arguments.

Add documentation for the new option. In the documentation, make it clear that
the exact format of the output is not a stable guarantee.

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

joshtriplett added the T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

label

Dec 6, 2021

joshtriplett changed the titlestabilize print link args Stabilize -Z print-link-args as -C print-link-args

Dec 6, 2021

jyn514 added the needs-fcp

This change is insta-stable, so needs a completed FCP to proceed.

label

Dec 6, 2021

Collaborator

rfcbot commented

Dec 13, 2021

•

edited by michaelwoerister

Loading

We actually have this option for printing something:

    --print [crate-name|file-names|sysroot|target-libdir|cfg|target-list|target-cpus|target-features|relocation-models|code-models|tls-models|target-spec-json|native-static-libs]
                    Compiler information to print on stdout

--print link-args would also fit well.

-C options are supposed to be for Codegen after all, which -Cprint-link-args is not.

@rfcbot concern "consider changing to --print link-args"

@petrochenkov this specific options has output that can depend on the source code input, right?

Is there precedent for other --print variants that depend on the source input? (Its an honest question; I'm not familiar with all the options listed, and could imagine that they all don't have such dependence, or that some do.)

Is there precedent for other --print variants that depend on the source input?

--print native-static-libs, for example.

@petrochenkov --print link-args seems reasonable; I'll look at what it would take to do that.

joshtriplett changed the titleStabilize -Z print-link-args as -C print-link-args Stabilize -Z print-link-args as --print link-args

Jan 9, 2022

This comment has been minimized.

We have stable options for adding linker arguments; we should have a stable option to help debug linker arguments.

The documentation makes it clear that the exact format of the output is not a stable guarantee.

@petrochenkov Done; this PR now stabilizes -Z print-link-args as --print link-args instead.

@rfcbot resolve "consider changing to --print link-args"

🔔 This is now entering its final comment period, as per the review above. 🔔

📌 Commit 371bd46 has been approved by pnkfelix

🌲 The tree is currently closed for pull requests below priority 600. This pull request will be tested once the tree is reopened.

bors added the S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

label

Jan 20, 2022

pnkfelix added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Jan 20, 2022

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2022

…askrgr

Rollup of 13 pull requests

Successful merges:

• rust-lang#89747 (Add MaybeUninit::(slice_)as_bytes(_mut))
• rust-lang#89764 (Fix variant index / discriminant confusion in uninhabited enum branching)
• rust-lang#91606 (Stabilize -Z print-link-args as --print link-args)
• rust-lang#91694 (rustdoc: decouple stability and const-stability)
• rust-lang#92183 (Point at correct argument when async fn output type lifetime disagrees with signature)
• rust-lang#92582 (improve _ constants in item signature handling)
• rust-lang#92680 (intra-doc: Use the impl's assoc item where possible)
• rust-lang#92704 (Change lint message to be stronger for &T -> &mut T transmute)
• rust-lang#92861 (Rustdoc mobile: put out-of-band info on its own line)
• rust-lang#92992 (Help optimize out backtraces when disabled)
• rust-lang#93038 (Fix star handling in block doc comments)
• rust-lang#93108 (:arrow_up: rust-analyzer)
• rust-lang#93112 (Fix CVE-2022-21658)

Failed merges:

r? @ghost @rustbot modify labels: rollup

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Apr 15, 2022

Pkgsrc changes:

• Bump available bootstraps to 1.59.0.
• Delete one patch which no longer applies, adjust another.

Upstream changes:

Version 1.60.0 (2022-04-07)

Language

• [Stabilize #[cfg(panic = "...")] for either "unwind" or "abort".] 93658
• Stabilize #[cfg(target_has_atomic = "...")] for each integer size and "ptr".

Compiler

• Enable combining +crt-static and relocation-model=pic on x86_64-unknown-linux-gnu
• Fixes wrong unreachable_pub lints on nested and glob public reexport
• Stabilize -Z instrument-coverage as -C instrument-coverage
• Stabilize -Z print-link-args as --print link-args
• Add new Tier 3 target mips64-openwrt-linux-musl*
• Add new Tier 3 target armv7-unknown-linux-uclibceabi (softfloat)*
• Fix invalid removal of newlines from doc comments
• Add kernel target for RustyHermit
• Deny mixing bin crate type with lib crate types
• Make rustc use RUST_BACKTRACE=full by default
• Upgrade to LLVM 14

* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.

Libraries

• Guarantee call order for sort_by_cached_key
• Improve Duration::try_from_secs_f32/f64 accuracy by directly processing exponent and mantissa
• Make Instant::{duration_since, elapsed, sub} saturating
• Remove non-monotonic clocks workarounds in Instant::now
• Make BuildHasherDefault, iter::Empty and future::Pending covariant

Stabilized APIs

• Arc::new_cyclic
• Rc::new_cyclic
• slice::EscapeAscii
• <[u8]>::escape_ascii
• u8::escape_ascii
• Vec::spare_capacity_mut
• MaybeUninit::assume_init_drop
• MaybeUninit::assume_init_read
• i8::abs_diff
• i16::abs_diff
• i32::abs_diff
• i64::abs_diff
• i128::abs_diff
• isize::abs_diff
• u8::abs_diff
• u16::abs_diff
• u32::abs_diff
• u64::abs_diff
• u128::abs_diff
• usize::abs_diff
• Display for io::ErrorKind
• From<u8> for ExitCode
• Not for ! (the "never" type)
• OpAssign<$t> for Wrapping<$t>
• arch::is_aarch64_feature_detected!

Cargo

• Port cargo from toml-rs to toml_edit
• Stabilize -Ztimings as --timings
• Stabilize namespaced and weak dependency features.
• Accept more cargo:rustc-link-arg-* types from build script output.
• cargo-new should not add ignore rule on Cargo.lock inside subdirs

Misc

• Ship docs on Tier 2 platforms by reusing the closest Tier 1 platform docs
• Drop rustc-docs from complete profile
• bootstrap: tidy up flag handling for llvm build

Compatibility Notes

• Remove compiler-rt linking hack on Android
• Mitigations for platforms with non-monotonic clocks have been removed from Instant::now. On platforms that don't provide monotonic clocks, an instant is not guaranteed to be greater than an earlier instant anymore.
• Instant::{duration_since, elapsed, sub} do not panic anymore on underflow, saturating to 0 instead. In the real world the panic happened mostly on platforms with buggy monotonic clock implementations rather than catching programming errors like reversing the start and end times. Such programming errors will now results in 0 rather than a panic.
• In a future release we're planning to increase the baseline requirements for the Linux kernel to version 3.2, and for glibc to version 2.17. We'd love your feedback in PR #95026.

Internal Changes

These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools.

• Switch all libraries to the 2021 edition

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

May 25, 2022

Labels

disposition-merge

This issue / PR is in PFCP or FCP with a disposition to merge it.

finished-final-comment-period

The final comment period is finished for this PR / Issue.

needs-fcp

This change is insta-stable, so needs a completed FCP to proceed.

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.