Use TraitEngine in more places that don't specifically need FulfillmentContext::new_in_snapshot by compiler-errors · Pull Request #99746 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Not sure if this change is worthwhile, but couldn't hurt re: chalkification
r? types
Relevant to the compiler team, which will review and decide on the PR/issue.
label
This comment has been minimized.
side note: I can't check how this affects chalk migrate-mode tests b/c some of them hang forever, lol.
re-rolling for spastorino
r? types
📌 Commit 58f107a has been approved by jackh726
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
…r=jackh726
Use TraitEngine in more places that don't specifically need FulfillmentContext::new_in_snapshot
Not sure if this change is worthwhile, but couldn't hurt re: chalkification
r? types
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#98771 (Add support for link-flavor rust-lld for iOS, tvOS and watchOS)
- rust-lang#98835 (relate
closure_substs.parent_substs()to parent fn in NLL) - rust-lang#99746 (Use
TraitEnginein more places that don't specifically needFulfillmentContext::new_in_snapshot) - rust-lang#99786 (Recover from C++ style
enum struct) - rust-lang#99795 (Delay a bug when failed to normalize trait ref during specialization)
- rust-lang#100029 (Prevent ICE for
doc_aliason match arm, statement, expression)
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Manishearth added a commit to Manishearth/rust that referenced this pull request
…wesleywiser
Use TraitEngine in more places, restrict visibility of FulfillmentCtxt constructor
Most places that are constructing a FulfillmentContext should be constructing a TraitEngine generically, so later on if/when we're transitioning it'll be easier.
Logical extension of rust-lang#99746
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.