Add support for link-flavor rust-lld for iOS, tvOS and watchOS by marysaka · Pull Request #98771 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation20 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This adds support for rust-lld for Apple *OS targets.
This was tested against targets aarch64-apple-ios
and aarch64-apple-ios-sim
with a simple test program.
It currently doesn't work with targets armv7-apple-ios
and armv7s-apple-ios
because of symbols.o
not being generated with the correct CPU subtype. This will require changes in the object
crate to expose an API.
As ld64.lld
requires -platform_version
with the minimal version supported and an sdk version, I made rustc_target::apple_base
public to get access to *os_deployment_target
helper functions and also added tvos_deployment_target
as it was missing.
rustbot added the T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Sorry for the delay, I should be able to review this some time this week.
@Thog
Any logic that cannot fail is supposed to go to target definitions in rustc_target
.
That's why the *_deployment_target
are currently private - they are used from rustc_target
and that's enough.
Only get_apple_sdk_root
really needs to be delayed until link time.
(Even the pre-existing cmd.args(&["-target", llvm_target])
and cmd.args(&["-arch", arch_name])
are misplaced and can be moved to rustc_target
, I think.)
@rustbot author
rustbot added S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
@Thog Any logic that cannot fail is supposed to go to target definitions in
rustc_target
. That's why the*_deployment_target
are currently private - they are used fromrustc_target
and that's enough.Only
get_apple_sdk_root
really needs to be delayed until link time. (Even the pre-existingcmd.args(&["-target", llvm_target])
andcmd.args(&["-arch", arch_name])
are misplaced and can be moved torustc_target
, I think.)@rustbot author
I was not sure where to put that part initially, I will address this hopefully this week 👍
After a quick look it seems that ios_llvm_target
, ios_sim_llvm_target
and watchos_sim_llvm_target
are used for iOS and watchOS simulator target definitions.
However, at the time of writing arm64_32-apple-watchos and arm64-apple-tvos doesn't select the llvm target with the deployment target.
Should I change those definitions in this PR to make them conform to watchos_deployment_target
and tvos_deployment_target
respectively?
@Thog
I'm not sure, I'm more familiar with the compiler infrastructure around rustc_target
than with details of Apple targets specifically.
You can ping people who added those targets, or maybe PRs adding those targets have some answers.
@petrochenkov I did a refactoring of the linker arguments as suggested and rebased. However, the unit tests that you introduced with #98212 are failing here.
As I understand it, the test checks that the flavor
of every LinkArg
match the linker_flavor
of the target. That's unwanted here as I'm targeting ld.64
specifically and result on a failure.
Shouldn't this actually check that at least one flavor
match the linker_flavor
?
@Thog I'm not sure, I'm more familiar with the compiler infrastructure around
rustc_target
than with details of Apple targets specifically. You can ping people who added those targets, or maybe PRs adding those targets have some answers.
I think I will try to handle those changes in a separated PR later
The unit test needs to be updated, to something like
--- a/compiler/rustc_target/src/spec/tests/tests_impl.rs +++ b/compiler/rustc_target/src/spec/tests/tests_impl.rs @@ -46,7 +46,10 @@ fn check_consistency(&self) { ) } (LinkerFlavor::Gcc, LldFlavor::Ld64) => {
assert_matches!(flavor, LinkerFlavor::Gcc)
assert_matches!(
flavor,
LinkerFlavor::Lld(LldFlavor::Ld64) | LinkerFlavor::Gcc
) } (LinkerFlavor::Msvc | LinkerFlavor::Lld(LldFlavor::Link), LldFlavor::Link) => { assert_matches!(
This case just didn't occur previously.
@rustbot label -S-waiting-on-author +S-waiting-on-review
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Could you also squash commits into one after addressing the comments?
@rustbot author
rustbot added S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This adds support for rust-lld for Apple *OS targets.
This was tested against targets "aarch64-apple-ios" and "aarch64-apple-ios-sim".
For targets "armv7-apple-ios" and "armv7s-apple-ios", it doesn't link because of "symbols.o" not being generated with the correct CPU subtype (changes in the "object" crate needs to be done to support it).
@rustbot label -S-waiting-on-author +S-waiting-on-review
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 78bbe57 has been approved by petrochenkov
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#98771 (Add support for link-flavor rust-lld for iOS, tvOS and watchOS)
- rust-lang#98835 (relate
closure_substs.parent_substs()
to parent fn in NLL) - rust-lang#99746 (Use
TraitEngine
in more places that don't specifically needFulfillmentContext::new_in_snapshot
) - rust-lang#99786 (Recover from C++ style
enum struct
) - rust-lang#99795 (Delay a bug when failed to normalize trait ref during specialization)
- rust-lang#100029 (Prevent ICE for
doc_alias
on match arm, statement, expression)
Failed merges:
r? @ghost
@rustbot
modify labels: rollup
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request
Pkgsrc changes:
- Add patch to fix vendor/kqueue issue (on 32-bit hosts)
- Adjust other patches & line numbers
- Version bumps & checksum changes.
Upstream changes:
Version 1.64.0 (2022-09-22)
Language
Unions with mutable references or tuples of allowed types are now allowed
It is now considered valid to deallocate memory pointed to by a shared reference
&T
if every byte inT
is inside anUnsafeCell
Unused tuple struct fields are now warned against in an allow-by-default lint, [
unused_tuple_struct_fields
] (rust-lang/rust#95977), similar to the existing warning for unused struct fields. This lint will become warn-by-default in the future.
Compiler
- [Add Nintendo Switch as tier 3 target]
(rust-lang/rust#88991)
- Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.
- [Only compile
#[used]
as llvm.compiler.used for ELF targets] (rust-lang/rust#93718) - [Add the
--diagnostic-width
compiler flag to define the terminal width.] (rust-lang/rust#95635) - [Add support for link-flavor
rust-lld
for iOS, tvOS and watchOS] (rust-lang/rust#98771)
Libraries
- [Remove restrictions on compare-exchange memory ordering.] (rust-lang/rust#98383)
- You can now
write!
orwriteln!
into anOsString
: Implementfmt::Write
forOsString
- [Make RwLockReadGuard covariant] (rust-lang/rust#96820)
- [Implement
FusedIterator
forstd:🥅:[Into]Incoming
] (rust-lang/rust#97300) - [
impl<T: AsRawFd> AsRawFd for {Arc,Box}<T>
] (rust-lang/rust#97437) - [
ptr::copy
andptr::swap
are doing untyped copies] (rust-lang/rust#97712) - [Add cgroupv1 support to
available_parallelism
] (rust-lang/rust#97925) - [Mitigate many incorrect uses of
mem::uninitialized
] (rust-lang/rust#99182)
Stabilized APIs
- [
future::IntoFuture
] (https://doc.rust-lang.org/stable/std/future/trait.IntoFuture.html) - [
future::poll_fn
] (https://doc.rust-lang.org/stable/std/future/fn.poll_fn.html) - [
task::ready!
] (https://doc.rust-lang.org/stable/std/task/macro.ready.html) - [
num::NonZero*::checked_mul
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_mul) - [
num::NonZero*::checked_pow
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_pow) - [
num::NonZero*::saturating_mul
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_mul) - [
num::NonZero*::saturating_pow
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_pow) - [
num::NonZeroI*::abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.abs) - [
num::NonZeroI*::checked_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.checked_abs) - [
num::NonZeroI*::overflowing_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.overflowing_abs) - [
num::NonZeroI*::saturating_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.saturating_abs) - [
num::NonZeroI*::unsigned_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.unsigned_abs) - [
num::NonZeroI*::wrapping_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.wrapping_abs) - [
num::NonZeroU*::checked_add
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_add) - [
num::NonZeroU*::checked_next_power_of_two
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_next_power_of_two) - [
num::NonZeroU*::saturating_add
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_add) - [
os::unix::process::CommandExt::process_group
] (https://doc.rust-lang.org/stable/std/os/unix/process/trait.CommandExt.html#tymethod.process_group) - [
os::windows::fs::FileTypeExt::is_symlink_dir
] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_dir) - [
os::windows::fs::FileTypeExt::is_symlink_file
] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_file)
These types were previously stable in std::ffi
, but are now also
available in core
and alloc
:
- [
core::ffi::CStr
] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html) - [
core::ffi::FromBytesWithNulError
] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesWithNulError.html) - [
alloc::ffi::CString
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.CString.html) - [
alloc::ffi::FromVecWithNulError
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.FromVecWithNulError.html) - [
alloc::ffi::IntoStringError
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.IntoStringError.html) - [
alloc::ffi::NulError
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.NulError.html)
These types were previously stable in std::os::raw
, but are now also available in core::ffi
and std::ffi
:
- [
ffi::c_char
] (https://doc.rust-lang.org/stable/std/ffi/type.c_char.html) - [
ffi::c_double
] (https://doc.rust-lang.org/stable/std/ffi/type.c_double.html) - [
ffi::c_float
] (https://doc.rust-lang.org/stable/std/ffi/type.c_float.html) - [
ffi::c_int
] (https://doc.rust-lang.org/stable/std/ffi/type.c_int.html) - [
ffi::c_long
] (https://doc.rust-lang.org/stable/std/ffi/type.c_long.html) - [
ffi::c_longlong
] (https://doc.rust-lang.org/stable/std/ffi/type.c_longlong.html) - [
ffi::c_schar
] (https://doc.rust-lang.org/stable/std/ffi/type.c_schar.html) - [
ffi::c_short
] (https://doc.rust-lang.org/stable/std/ffi/type.c_short.html) - [
ffi::c_uchar
] (https://doc.rust-lang.org/stable/std/ffi/type.c_uchar.html) - [
ffi::c_uint
] (https://doc.rust-lang.org/stable/std/ffi/type.c_uint.html) - [
ffi::c_ulong
] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulong.html) - [
ffi::c_ulonglong
] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulonglong.html) - [
ffi::c_ushort
] (https://doc.rust-lang.org/stable/std/ffi/type.c_ushort.html)
These APIs are now usable in const contexts:
- [
slice::from_raw_parts
] (https://doc.rust-lang.org/stable/core/slice/fn.from_raw_parts.html)
Cargo
- [Packages can now inherit settings from the workspace so that
the settings can be centralized in one place.]
(rust-lang/cargo#10859) See
workspace.package
andworkspace.dependencies
for more details on how to define these common settings. - [Cargo commands can now accept multiple
--target
flags to build for multiple targets at once] (rust-lang/cargo#10766), and thebuild.target
config option may now take an array of multiple targets. - [The
--jobs
argument can now take a negative number to count backwards from the max CPUs.] (rust-lang/cargo#10844) - [
cargo add
will now updateCargo.lock
.] (rust-lang/cargo#10902) - Added the
--crate-type
flag tocargo rustc
to override the crate type. - [Significantly improved the performance fetching git dependencies from GitHub
when using a hash in the
rev
field.] (rust-lang/cargo#10079)
Misc
- [The
rust-analyzer
rustup component is now available on the stable channel.] (rust-lang/rust#98640)
Compatibility Notes
- The minimum required versions for all
-linux-gnu
targets are now at least kernel 3.2 and glibc 2.17, for targets that previously supported older versions: Increase the minimum linux-gnu versions - [Network primitives are now implemented with the ideal Rust layout, not the C system layout] (rust-lang/rust#78802). This can cause problems when transmuting the types.
- [Add assertion that
transmute_copy
'sU
is not larger thanT
] (rust-lang/rust#98839) - [A soundness bug in
BTreeMap
was fixed] (rust-lang/rust#99413) that allowed data it was borrowing to be dropped before the container. - [The Drop behavior of C-like enums cast to ints has changed] (rust-lang/rust#96862). These are already discouraged by a compiler warning.
- [Relate late-bound closure lifetimes to parent fn in NLL] (rust-lang/rust#98835)
- [Errors at const-eval time are now in future incompatibility reports] (rust-lang/rust#97743)
- On the
thumbv6m-none-eabi
target, some incorrectasm!
statements were erroneously accepted if they used the high registers (r8 to r14) as an input/output operand. [This is no longer accepted] (rust-lang/rust#99155). - [
impl Trait
was accidentally accepted as the associated type value of return-positionimpl Trait
] (rust-lang/rust#97346), without fulfilling all the trait bounds of that associated type, as long as the hidden type satisfies said bounds. This has been fixed.
Internal Changes
These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.
- Windows builds now use profile-guided optimization, providing 10-20% improvements to compiler performance: [Utilize PGO for windows x64 rustc dist builds] (rust-lang/rust#96978)
- [Stop keeping metadata in memory before writing it to disk] (rust-lang/rust#96544)
- [compiletest: strip debuginfo by default for mode=ui] (rust-lang/rust#98140)
- Many improvements to generated code for derives, including
performance improvements:
- [Don't use match-destructuring for derived ops on structs.] (rust-lang/rust#98446)
- [Many small deriving cleanups] (rust-lang/rust#98741)
- [More derive output improvements] (rust-lang/rust#98758)
- Clarify deriving code
- [Final derive output improvements] (rust-lang/rust#99046)
- Stop injecting
#[allow(unused_qualifications)]
in generatedderive
implementations - Improve
derive(Debug)
- Bump to clap 3
- fully move dropck to mir
- [Optimize
Vec::insert
for the case whereindex == len
.] (rust-lang/rust#98755) - [Convert rust-analyzer to an in-tree tool] (rust-lang/rust#99603)
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request
Pkgsrc changes:
- This package now contains rust-analyzer, so implicitly conflicts with that pkgsrc package. The same goes for the rust-src package.
- Add NetBSD/arm6 port
- Add unfinished NetBSD/mipsel port
- Revert the use of the internal LLVM, should now build with the new pkgsrc LLVM (15).
- Add depndence on compat80 for sparc64 to fix the build
- Adapt patches
- Add CHECK_INTERPRETER_SKIP for a few (mostly unused) files. (A proper fix may come later.)
Upstream changes:
Version 1.64.0 (2022-09-22)
Language
Unions with mutable references or tuples of allowed types are now allowed
It is now considered valid to deallocate memory pointed to by a shared reference
&T
if every byte inT
is inside anUnsafeCell
Unused tuple struct fields are now warned against in an allow-by-default lint, [
unused_tuple_struct_fields
] (rust-lang/rust#95977), similar to the existing warning for unused struct fields. This lint will become warn-by-default in the future.
Compiler
- [Add Nintendo Switch as tier 3 target]
(rust-lang/rust#88991)
- Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.
- [Only compile
#[used]
as llvm.compiler.used for ELF targets] (rust-lang/rust#93718) - [Add the
--diagnostic-width
compiler flag to define the terminal width.] (rust-lang/rust#95635) - [Add support for link-flavor
rust-lld
for iOS, tvOS and watchOS] (rust-lang/rust#98771)
Libraries
- [Remove restrictions on compare-exchange memory ordering.] (rust-lang/rust#98383)
- You can now
write!
orwriteln!
into anOsString
: Implementfmt::Write
forOsString
- [Make RwLockReadGuard covariant] (rust-lang/rust#96820)
- [Implement
FusedIterator
forstd:🥅:[Into]Incoming
] (rust-lang/rust#97300) - [
impl<T: AsRawFd> AsRawFd for {Arc,Box}<T>
] (rust-lang/rust#97437) - [
ptr::copy
andptr::swap
are doing untyped copies] (rust-lang/rust#97712) - [Add cgroupv1 support to
available_parallelism
] (rust-lang/rust#97925) - [Mitigate many incorrect uses of
mem::uninitialized
] (rust-lang/rust#99182)
Stabilized APIs
- [
future::IntoFuture
] (https://doc.rust-lang.org/stable/std/future/trait.IntoFuture.html) - [
future::poll_fn
] (https://doc.rust-lang.org/stable/std/future/fn.poll_fn.html) - [
task::ready!
] (https://doc.rust-lang.org/stable/std/task/macro.ready.html) - [
num::NonZero*::checked_mul
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_mul) - [
num::NonZero*::checked_pow
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_pow) - [
num::NonZero*::saturating_mul
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_mul) - [
num::NonZero*::saturating_pow
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_pow) - [
num::NonZeroI*::abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.abs) - [
num::NonZeroI*::checked_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.checked_abs) - [
num::NonZeroI*::overflowing_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.overflowing_abs) - [
num::NonZeroI*::saturating_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.saturating_abs) - [
num::NonZeroI*::unsigned_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.unsigned_abs) - [
num::NonZeroI*::wrapping_abs
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.wrapping_abs) - [
num::NonZeroU*::checked_add
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_add) - [
num::NonZeroU*::checked_next_power_of_two
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_next_power_of_two) - [
num::NonZeroU*::saturating_add
] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_add) - [
os::unix::process::CommandExt::process_group
] (https://doc.rust-lang.org/stable/std/os/unix/process/trait.CommandExt.html#tymethod.process_group) - [
os::windows::fs::FileTypeExt::is_symlink_dir
] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_dir) - [
os::windows::fs::FileTypeExt::is_symlink_file
] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_file)
These types were previously stable in std::ffi
, but are now also
available in core
and alloc
:
- [
core::ffi::CStr
] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html) - [
core::ffi::FromBytesWithNulError
] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesWithNulError.html) - [
alloc::ffi::CString
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.CString.html) - [
alloc::ffi::FromVecWithNulError
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.FromVecWithNulError.html) - [
alloc::ffi::IntoStringError
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.IntoStringError.html) - [
alloc::ffi::NulError
] (https://doc.rust-lang.org/stable/alloc/ffi/struct.NulError.html)
These types were previously stable in std::os::raw
, but are now
also available in core::ffi
and std::ffi
:
- [
ffi::c_char
] (https://doc.rust-lang.org/stable/std/ffi/type.c_char.html) - [
ffi::c_double
] (https://doc.rust-lang.org/stable/std/ffi/type.c_double.html) - [
ffi::c_float
] (https://doc.rust-lang.org/stable/std/ffi/type.c_float.html) - [
ffi::c_int
] (https://doc.rust-lang.org/stable/std/ffi/type.c_int.html) - [
ffi::c_long
] (https://doc.rust-lang.org/stable/std/ffi/type.c_long.html) - [
ffi::c_longlong
] (https://doc.rust-lang.org/stable/std/ffi/type.c_longlong.html) - [
ffi::c_schar
] (https://doc.rust-lang.org/stable/std/ffi/type.c_schar.html) - [
ffi::c_short
] (https://doc.rust-lang.org/stable/std/ffi/type.c_short.html) - [
ffi::c_uchar
] (https://doc.rust-lang.org/stable/std/ffi/type.c_uchar.html) - [
ffi::c_uint
] (https://doc.rust-lang.org/stable/std/ffi/type.c_uint.html) - [
ffi::c_ulong
] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulong.html) - [
ffi::c_ulonglong
] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulonglong.html) - [
ffi::c_ushort
] (https://doc.rust-lang.org/stable/std/ffi/type.c_ushort.html)
These APIs are now usable in const contexts:
- [
slice::from_raw_parts
] (https://doc.rust-lang.org/stable/core/slice/fn.from_raw_parts.html)
Cargo
- [Packages can now inherit settings from the workspace so that
the settings can be centralized in one place.]
(rust-lang/cargo#10859) See
workspace.package
andworkspace.dependencies
for more details on how to define these common settings. - [Cargo commands can now accept multiple
--target
flags to build for multiple targets at once] (rust-lang/cargo#10766), and thebuild.target
config option may now take an array of multiple targets. - [The
--jobs
argument can now take a negative number to count backwards from the max CPUs.] (rust-lang/cargo#10844) - [
cargo add
will now updateCargo.lock
.] (rust-lang/cargo#10902) - Added the
--crate-type
flag tocargo rustc
to override the crate type. - [Significantly improved the performance fetching git dependencies from GitHub
when using a hash in the
rev
field.] (rust-lang/cargo#10079)
Misc
- [The
rust-analyzer
rustup component is now available on the stable channel.] (rust-lang/rust#98640)
Compatibility Notes
- The minimum required versions for all
-linux-gnu
targets are now at least kernel 3.2 and glibc 2.17, for targets that previously supported older versions: Increase the minimum linux-gnu versions - [Network primitives are now implemented with the ideal Rust layout, not the C system layout] (rust-lang/rust#78802). This can cause problems when transmuting the types.
- [Add assertion that
transmute_copy
'sU
is not larger thanT
] (rust-lang/rust#98839) - [A soundness bug in
BTreeMap
was fixed] (rust-lang/rust#99413) that allowed data it was borrowing to be dropped before the container. - [The Drop behavior of C-like enums cast to ints has changed] (rust-lang/rust#96862). These are already discouraged by a compiler warning.
- [Relate late-bound closure lifetimes to parent fn in NLL] (rust-lang/rust#98835)
- [Errors at const-eval time are now in future incompatibility reports] (rust-lang/rust#97743)
- On the
thumbv6m-none-eabi
target, some incorrectasm!
statements were erroneously accepted if they used the high registers (r8 to r14) as an input/output operand. [This is no longer accepted] (rust-lang/rust#99155). - [
impl Trait
was accidentally accepted as the associated type value of return-positionimpl Trait
] (rust-lang/rust#97346), without fulfilling all the trait bounds of that associated type, as long as the hidden type satisfies said bounds. This has been fixed.
Internal Changes
These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.
- Windows builds now use profile-guided optimization, providing 10-20% improvements to compiler performance: [Utilize PGO for windows x64 rustc dist builds] (rust-lang/rust#96978)
- [Stop keeping metadata in memory before writing it to disk] (rust-lang/rust#96544)
- [compiletest: strip debuginfo by default for mode=ui] (rust-lang/rust#98140)
- Many improvements to generated code for derives, including
performance improvements:
- [Don't use match-destructuring for derived ops on structs.] (rust-lang/rust#98446)
- [Many small deriving cleanups] (rust-lang/rust#98741)
- [More derive output improvements] (rust-lang/rust#98758)
- Clarify deriving code
- [Final derive output improvements] (rust-lang/rust#99046)
- Stop injecting
#[allow(unused_qualifications)]
in generatedderive
implementations - Improve
derive(Debug)
- Bump to clap 3
- fully move dropck to mir
- [Optimize
Vec::insert
for the case whereindex == len
.] (rust-lang/rust#98755) - [Convert rust-analyzer to an in-tree tool] (rust-lang/rust#99603)
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.