dns: remove dns.promises experimental warning by cjihrig · Pull Request #26592 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

In a similar spirit to #26581.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

i have a similar concern here.

as long as x.promises existing doesn't block x/promises from existing this is probably fine.

Same question as in the other PR: This leaves it as experimental in the docs. That's intentional? (I'd prefer we make it stable in the docs and label this semver-major but that's just me!)

Perhaps it's time just to take it out of experimental?

Did we get feedback or reported usage ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @jdalton suggested in the other PR, it probably makes sense to make this enumerable as well

as long as x.promises existing doesn't block x/promises from existing this is probably fine.

It shouldn't block it.

This leaves it as experimental in the docs.

I've add a semver major commit to address it.

Perhaps it's time just to take it out of experimental?

Agreed. It's been ~9 months with no significant issues.

Did we get feedback or reported usage ?

Not that I'm aware of.

it probably makes sense to make this enumerable as well

Done.

cjihrig added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Mar 28, 2019

This requires @nodejs/tsc review because it's semver major. (@addaleax you may want to re-review).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR-URL: nodejs#26592 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com

@cjihrig Sorry, I missed that you had labelled this semver-major. Is there any particular reason? I’d prefer to remove the label.

@addaleax because of the change in enumerability. I was being overly cautious, and would also be fine dropping the label.

addaleax added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Apr 2, 2019

addaleax removed the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Apr 2, 2019

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

PR-URL: #26592 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

BethGriggs pushed a commit that referenced this pull request

Apr 8, 2019

BethGriggs pushed a commit that referenced this pull request

Apr 8, 2019

BethGriggs pushed a commit that referenced this pull request

Apr 8, 2019

BethGriggs added a commit that referenced this pull request

Apr 10, 2019

Notable changes:

child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
dns:
- make dns.promises enumerable (cjihrig) #26592
- remove dns.promises experimental warning (cjihrig) #26592
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

BethGriggs added a commit that referenced this pull request

Apr 11, 2019

Notable changes:

child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
dns:
- make dns.promises enumerable (cjihrig) #26592
- remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581)
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

BethGriggs added a commit that referenced this pull request

Apr 11, 2019

Notable changes:

child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
dns:
- make dns.promises enumerable (cjihrig) #26592
- remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581)
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

BethGriggs pushed a commit that referenced this pull request

Oct 18, 2019

BethGriggs pushed a commit that referenced this pull request

Oct 18, 2019

BethGriggs pushed a commit that referenced this pull request

Oct 18, 2019

BethGriggs added a commit that referenced this pull request

Oct 18, 2019

Notable changes:

deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
dns: remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
n-api: mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 19, 2019

Notable changes:

deps: update npm to 6.11.3 (claudiahdz) #29430
deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
dns: remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
n-api: mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 21, 2019

Notable changes:

deps: update npm to 6.11.3 (claudiahdz) #29430
deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
dns: remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
n-api: mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 22, 2019

Notable changes:

crypto:
- add support for chacha20-poly1305 for AEAD (chux0519) #24081
- increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799
deps:
- update npm to 6.11.3 (claudiahdz) #29430
- upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
dns:
- remove dns.promises experimental warning (cjihrig) #26592
fs:
- remove experimental warning for fs.promises (Anna Henningsen) #26581
http:
- makes response.writeHead return the response (Mark S. Everitt) #25974
http2:
- makes response.writeHead return the response (Mark S. Everitt) #25974
n-api:
- make func argument of napi_create_threadsafe_function optional (legendecas) #27791
- mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
- implement date object (Jarrod Connolly) #25917
process:
- add --unhandled-rejections flag (Ruben Bridgewater) #26599
stream:
- implement Readable.from async iterator utility (Guy Bedford) #27660
- make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 22, 2019

Notable changes:

crypto:
- add support for chacha20-poly1305 for AEAD (chux0519) #24081
- increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799
deps:
- update npm to 6.11.3 (claudiahdz) #29430
- upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
dns:
- remove dns.promises experimental warning (cjihrig) #26592
fs:
- remove experimental warning for fs.promises (Anna Henningsen) #26581
http:
- makes response.writeHead return the response (Mark S. Everitt) #25974
http2:
- makes response.writeHead return the response (Mark S. Everitt) #25974
n-api:
- make func argument of napi_create_threadsafe_function optional (legendecas) #27791
- mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
- implement date object (Jarrod Connolly) #25917
process:
- add --unhandled-rejections flag (Ruben Bridgewater) #26599
stream:
- implement Readable.from async iterator utility (Guy Bedford) #27660
- make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

Labels

dns

Issues and PRs related to the dns subsystem.

semver-minor

PRs that contain new features and should be released in the next minor version.