stream: make async iteration stable by mcollina · Pull Request #26989 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation20 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I think it's about time we make Readable async iteration stable.
It has been around for a while - we have fixed a bunch of bugs so far, and I expect there will still be some. I do not expect major changes.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

guybedford, reconbot, bnb, jleedev, bricss, and octet-stream reacted with hooray emoji evelynhathaway, zenparsing, bricss, benjamingr, vsemozhetbyt, reconbot, bnb, and octet-stream reacted with heart emoji bricss and petrgrishin reacted with eyes emoji

mcollina added stream

Issues and PRs related to the stream subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Mar 29, 2019

@mcollina Sadly, an error occurred when I tried to trigger a build. :(

why semver-major?

I don't know really.

mcollina added semver-minor

PRs that contain new features and should be released in the next minor version.

and removed semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BridgeAR added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Mar 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

1 similar comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

PR-URL: #26989 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

PR-URL: #26989 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 10, 2019

PR-URL: #26989 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 10, 2019

PR-URL: #26989 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

BethGriggs added a commit that referenced this pull request

Apr 10, 2019

Notable changes:

• child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
• deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
• dns:
  • make dns.promises enumerable (cjihrig) #26592
  • remove dns.promises experimental warning (cjihrig) #26592
• stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
• worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

BethGriggs added a commit that referenced this pull request

Apr 11, 2019

Notable changes:

• child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
• deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
• dns:
  • make dns.promises enumerable (cjihrig) #26592
  • remove dns.promises experimental warning (cjihrig) #26592
• fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581)
• stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
• worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

BethGriggs added a commit that referenced this pull request

Apr 11, 2019

Notable changes:

• child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
• deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
• dns:
  • make dns.promises enumerable (cjihrig) #26592
  • remove dns.promises experimental warning (cjihrig) #26592
• fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581)
• stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
• worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

@nodejs/lts would you mind including this in the next v10 minor?

@BethGriggs would you mind adding this to the next 10 release?

BethGriggs pushed a commit that referenced this pull request

Oct 18, 2019

PR-URL: #26989 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

BethGriggs pushed a commit that referenced this pull request

Oct 18, 2019

PR-URL: #26989 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

BethGriggs added a commit that referenced this pull request

Oct 18, 2019

Notable changes:

• deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
• dns: remove dns.promises experimental warning (cjihrig) #26592
• fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
• n-api: mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
• stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 19, 2019

Notable changes:

• deps: update npm to 6.11.3 (claudiahdz) #29430
• deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
• dns: remove dns.promises experimental warning (cjihrig) #26592
• fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
• n-api: mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
• stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 21, 2019

Notable changes:

• deps: update npm to 6.11.3 (claudiahdz) #29430
• deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
• dns: remove dns.promises experimental warning (cjihrig) #26592
• fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
• n-api: mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
• stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 22, 2019

Notable changes:

• crypto:
  • add support for chacha20-poly1305 for AEAD (chux0519) #24081
  • increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799
• deps:
  • update npm to 6.11.3 (claudiahdz) #29430
  • upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
• dns:
  • remove dns.promises experimental warning (cjihrig) #26592
• fs:
  • remove experimental warning for fs.promises (Anna Henningsen) #26581
• http:
  • makes response.writeHead return the response (Mark S. Everitt) #25974
• http2:
  • makes response.writeHead return the response (Mark S. Everitt) #25974
• n-api:
  • make func argument of napi_create_threadsafe_function optional (legendecas) #27791
  • mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
  • implement date object (Jarrod Connolly) #25917
• process:
  • add --unhandled-rejections flag (Ruben Bridgewater) #26599
• stream:
  • implement Readable.from async iterator utility (Guy Bedford) #27660
  • make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

BethGriggs added a commit that referenced this pull request

Oct 22, 2019

Notable changes:

• crypto:
  • add support for chacha20-poly1305 for AEAD (chux0519) #24081
  • increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799
• deps:
  • update npm to 6.11.3 (claudiahdz) #29430
  • upgrade openssl sources to 1.1.1d (Sam Roberts) #29921
• dns:
  • remove dns.promises experimental warning (cjihrig) #26592
• fs:
  • remove experimental warning for fs.promises (Anna Henningsen) #26581
• http:
  • makes response.writeHead return the response (Mark S. Everitt) #25974
• http2:
  • makes response.writeHead return the response (Mark S. Everitt) #25974
• n-api:
  • make func argument of napi_create_threadsafe_function optional (legendecas) #27791
  • mark version 5 N-APIs as stable (Gabriel Schulhof) #29401
  • implement date object (Jarrod Connolly) #25917
• process:
  • add --unhandled-rejections flag (Ruben Bridgewater) #26599
• stream:
  • implement Readable.from async iterator utility (Guy Bedford) #27660
  • make Symbol.asyncIterator support stable (Matteo Collina) #26989

PR-URL: #29875

Reviewers

jasnell jasnell approved these changes

addaleax addaleax approved these changes

benjamingr benjamingr approved these changes

cjihrig cjihrig approved these changes

BridgeAR BridgeAR approved these changes

shisama shisama approved these changes

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

promises

Issues and PRs related to ECMAScript promises.

semver-minor

PRs that contain new features and should be released in the next minor version.

stream

Issues and PRs related to the stream subsystem.