v11.14.0 proposal by BethGriggs · Pull Request #27163 · nodejs/node (original) (raw)

Notable changes

child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
dns:
- make dns.promises enumerable (cjihrig) #26592
- remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
worker: use copy of process.env (Anna Henningsen) #26544

Commits

[ca7c4f485b] - async_hooks: minor cleanup and improvements (Anatoli Papirovski) #27034
[e9bffa8166] - benchmark: improve module-loader benchmark (Ruben Bridgewater) #26970
[09d6dfb21d] - benchmark: add new module loading benchmarks (Ruben Bridgewater) #26970
[5512ecb5b0] - benchmark: tidy up eslint ignore in foreach-bench.js (gengjiawen) #26925
[de937375e4] - benchmark: remove unused field in class BenchmarkProgress (gengjiawen) #26925
[0aea4d1c77] - benchmark,lib: change var to const (Ruben Bridgewater) #26915
[2ba58a6d54] - buffer: fix concat error message (Ruben Bridgewater) #27050
[a64786f47f] - build: fix inspector dependency resolution (Ben Noordhuis) #27026
[19a30f3b7e] - build: fix inspector dependency resolution (Ben Noordhuis) #27026
[ab5dbf9eb0] - build: only emit download ICU warnings once (Richard Lau) #27031
[7fe43bd81a] - build: remove unused label from vcbuild.bat (Ben Noordhuis) #26901
[6cbd6b5d57] - build: fix skipping of flaky tests on Travis (Richard Lau) #27002
[769d12ca9f] - build: add a Prepare ccache job in Travis (Richard Lau) #27002
[d8aaf2e0db] - build,meta: tweak Travis config (Refael Ackermann) #26969
[b64b22377c] - build,win: silence MSVC warning C4129 for V8 (Refael Ackermann) #27017
[23967431f5] - child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
[4defe47228] - child_process: reduce internal usage of public require of util (toshi1127) #26769
[e43dbaaba4] - console: remove unreachable code (Rich Trott) #26906
[2b791d8697] - crypto: fix crash of encrypted private key export without cipher (Filip Skokan) #27041
[1d2f4c4c6f] - crypto: fix crash of encrypted private key export without cipher (Filip Skokan) #27041
[98552f3630] - crypto: allow undefined for saltLength and padding (Tobias Nießen) #26921
[db7df0fb12] - deps: add ARM64 Windows configurations in openssl (Jon Kunkee) #26001
[341eacc949] - deps: add ARM64 Windows support in openssl (Shigeki Ohtsu) #26001
[247700f293] - (SEMVER-MINOR) deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
[af3ce38902] - dns: refactor lib/internal/dns/utils.js (Rich Trott) #27006
[ac12109d14] - (SEMVER-MINOR) dns: make dns.promises enumerable (cjihrig) #26592
[d3c1de313e] - (SEMVER-MINOR) dns: remove dns.promises experimental warning (cjihrig) #26592
[ff126ea13c] - doc: assign missed deprecation code (Richard Lau) #27164
[51dad0aaca] - doc: fix default maxBuffer size (kohta ito) #22894
[7eb73d301d] - doc: document the 'pause' and 'resume' events (Luigi Pinca) #26999
[57ced2db8c] - doc: remove unnecessary intro in governance doc (Rich Trott) #27036
[a5314a1af1] - doc: remove old system_errors (Minwoo Jung) #27037
[2d780f864b] - doc: unify link formatting in buffer.md (Vse Mozhet Byt) #27030
[6e3b6c5e2c] - doc: unify periods in comments in buffer.md (Vse Mozhet Byt) #27030
[5983cefbf9] - doc: add notes about negative offsets in buffer.md (Vse Mozhet Byt) #27030
[3567ff1378] - doc: mark optional parameters in buffer.md (Vse Mozhet Byt) #27030
[eeee6360b9] - doc: add note about Buffer octets integer coercion (Vse Mozhet Byt) #27030
[c3d573d743] - doc: fix error notes in Buffer.from() variants (Vse Mozhet Byt) #27030
[e18a0e8087] - doc: unify number/integer types in buffer.md (Vse Mozhet Byt) #27030
[0d75adcd71] - doc: add missing types in buffer.md (Vse Mozhet Byt) #27030
[231eff92ca] - doc: fix possible typo in buffer.md (Vse Mozhet Byt) #27030
[f475e79db3] - doc: remove description duplication in buffer.md (Vse Mozhet Byt) #27030
[7b37c65914] - doc: improve the doc of the 'information' event (Luigi Pinca) #27009
[c4b790b62b] - doc: move "Prints: ..." under the code (simon3000) #27035
[0f08a8e081] - doc: add information about modules cache behavior (Ruben Bridgewater) #26971
[b88871e80b] - doc: list when promiseResolve hook was added to async_hooks (Thomas Watson) #26978
[7a391961ea] - doc: change code lang and update it with latest Node.js (gengjiawen) #26987
[17cc117f4a] - doc: update changelog for v10.x LTS (Beth Griggs) #26931
[28efecccd5] - doc: remove "How is an LTS release cut?" section (Rich Trott) #26955
[d76c30c082] - doc: add note about mkdtemp() platform differences (cjihrig) #26944
[4a7a84a6be] - (SEMVER-MINOR) doc: move dns.promises to stable status (cjihrig) #26592
[25d5198001] - doc: change links to https in benchmark guide (gengjiawen) #26925
[a821a96b50] - doc: correct typo: cert.issuerCertificate (Steven R. Loomis)
[17bff5ca0d] - doc: remove reference to "credentials object" (Sam Roberts) #26908
[5e64acd66b] - (SEMVER-MINOR) embedding: make NewIsolate() API more flexible (Anna Henningsen) #26525
[7671a65dbb] - (SEMVER-MINOR) embedding: refactor public ArrayBufferAllocator API (Anna Henningsen) #26525
[c756b84447] - errors: make range mandatory in ERR_OUT_OF_RANGE (Ruben Bridgewater) #26924
[3e386a77d5] - (SEMVER-MINOR) fs: remove experimental warning for fs.promises (Anna Henningsen) #26581
[bb9f1cce42] - fs: reduce usage of require('util') (toshi1127) #26783
[5a29a94f0e] - http: reduce usage of public util (ZYSzys) #26548
[760d089e92] - inspector: display error when ToggleAsyncHook fails (Joyee Cheung) #26859
[1b45704c19] - inspector: patch C++ debug options instead of process._breakFirstLine (Joyee Cheung) #26602
[100bfc5131] - meta: move ofrobots to TSC emeritus (Ali Ijaz Sheikh) #27076
[5c39687d01] - module: add extra caching layer (Ruben Bridgewater) #26970
[9b27d5eebb] - module: add path to the module object (Ruben Bridgewater) #26970
[3263264f43] - module: inline try catch (Ruben Bridgewater) #26970
[079368a6ab] - module: fix repl require calling the same file again (Ruben Bridgewater) #26928
[3c9292642d] - module: simpler esm loading (Ruben Bridgewater) #26974
[fd8de13bbe] - path: refactor for less indentation (Ruben Bridgewater) #26917
[b62739c85c] - path: remove dead code (Ruben Bridgewater) #26916
[bd006e1002] - path: fix win32 parse regression (Ruben Bridgewater) #26912
[a232cd60dd] - process: store argv in Environment (Joyee Cheung) #26945
[4d06ef468e] - process: run RunBootstrapping in CreateEnvironment (Joyee Cheung) #26788
[a03552d246] - process: handle --expose-internals during pre-execution (Joyee Cheung) #26759
[75c5d9c5b7] - process: create legacy process properties during pre-execution (Joyee Cheung) #26517
[d4f95091d0] - process: delay process.argv[0] and process.argv0 handling (Joyee Cheung) #26517
[6c40f7f940] - querystring: simplify stringify method (ZYSzys) #26591
[dbd06088cf] - (SEMVER-MINOR) readline: make Symbol.asyncIterator support stable (Matteo Collina) #26989
[78fad3210c] - readline: replace quadratic regex with linear one (Thomas) #26778
[003e085ab5] - report: add cwd to report (cjihrig) #27022
[755609c682] - src: prevent crash in TTYWrap::Initialize (Thomas) #26832
[32ec034bdc] - src: use sizeof(var) instead of sizeof(type) (Ben Noordhuis) #27038
[c537daf391] - src: apply clang-tidy rule bugprone-incorrect-roundings (gengjiawen) #26885
[80694949f2] - src: elevate v8::Task namespace (Juan José Arboleda) #26909
[aa6a741102] - src: replace c-style cast (gengjiawen) #26888
[f65cb75c74] - src: remove internal includes from node_crypto.h (Sam Roberts) #26966
[d0ee1a3dbb] - src: fix warning on mismatched fn signature (Sam Roberts) #26950
[fbdead7f35] - src: add missing uv_fs_req_cleanup() (cjihrig) #27004
[729e2f242f] - src: implement generic backend for process.env (Anna Henningsen) #26544
[d3840bcf0d] - src: allow per-Environment set of env vars (Anna Henningsen) #26544
[e776b013ad] - src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt (Joyee Cheung) #26935
[0427354a98] - src: delete useless code in cares_wrap.cc (gengjiawen) #26815
[6bfb17f528] - src: fix task release in cares_wrap.cc (gengjiawen) #26815
[c969731755] - src: use deleted function for class BaseObject (gengjiawen) #26815
[c824127756] - src: delete unused field in class ModuleWrap (gengjiawen) #26815
[ea7e2c0666] - src: tidy up include headers in env.cc (gengjiawen) #26815
[c1def0701e] - src: delete unreachable code in heap_utils.cc (gengjiawen) #26815
[c51cc9e85b] - src: apply clang-tidy rule modernize-make-unique (gengjiawen) #26493
[ab70c96a79] - src: refactor coverage connection (Joyee Cheung) #26513
[63e7cc7694] - src: forbid access to CLI options before bootstrapping is done (Joyee Cheung) #26476
[e6c1ad5901] - src: fix warnings around node_options (Refael Ackermann) #26280
[62f904974d] - src: refactor node options parsers to mitigate MSVC bug (Refael Ackermann) #26280
[b29afa212a] - (SEMVER-MINOR) stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
[ea47189b40] - stream: do not unconditionally call \_read() on resume() (Anna Henningsen) #26965
[b359a7a7e5] - test: make module test pass with NODE_PENDING_DEPRECATION (Anna Henningsen) #27019
[1b2a07855a] - test: remove test-trace-events-api-worker-disabled from flaky (Rich Trott) #27020
[ecac6547c0] - test: move test that creates 1Gb file to pummel (Rich Trott) #27053
[35119d60d9] - test: add IPv6 brackets but no port to test-dns (Rich Trott) #27006
[8258f0704d] - test: remove unused triggerAsyncId param in test (Juan José Arboleda) #26800
[06dce392ba] - test: fix error code typo (cjihrig) #27024
[e5181f8dc4] - test: simplify for loop in test-buffer-zero-fill-cli.js (Juan José Arboleda) #26799
[9330d7e4bf] - test: add known_issues test for fs.copyFile() (Rich Trott) #26939
[fd6381b056] - test: remove test-path-parse-6229.js from known issues (Ruben Bridgewater) #26913
[edad9afaf8] - test: move hasCrypto check (Ruben Bridgewater) #26858
[2ef1bd97c6] - test: do not require flags when executing a file (Ruben Bridgewater) #26858
[a1cf7453d8] - test: refactor path parse test (Ruben Bridgewater) #26912
[80e845e787] - test: add test about unencrypted PKCS#8 private key for RSA (Daiki Ihara) #26898
[03bd649655] - test: show stderr on v8 coverage test failures (Joyee Cheung) #26513
[b24e45ab8d] - (SEMVER-MINOR) timers: deprecate active() and _unrefActive() (Jeremiah Senkpiel) #26760
[3ff3070442] - tools: fix test.py --time (Richard Lau) #27007
[7cbe1214d0] - tools: update ESLint to 5.16.0 (cjihrig) #27005
[dc9ce86aaa] - tools: update dependencies in lint-md-cli-rollup (Daijiro Wachi) #26889
[8798db3bf3] - url: add ws: and wss: to slashedProtocol set (Luigi Pinca) #26941
[12737b3789] - util: inspect() should not exceed breakLength (Ruben Bridgewater) #26914
[0f615d4216] - util: add subclass and null prototype support for errors in inspect (Ruben Bridgewater) #26923
[1aa6e993e3] - util: fix map entries inspection (Ruben Bridgewater) #26918
[1b08e622aa] - util: improve proxy inspection (Ruben Bridgewater) #26919
[21486e5c97] - util: extract uncurryThis function for reuse (ZYSzys) #23081
[169f3f7166] - util: require isNativeError from internalBinding (ZYSzys) #23081
[8bd7909d00] - worker: use copy of process.env (Anna Henningsen) #26544
[682b410581] - worker: allow execArgv and eval in combination (Anna Henningsen) #26533
[5d9f819a14] - worker: remove usage of require('util') in worker_thread.js (toshi1127) #26814
[44450efa6b] - worker: remove usage of require('util') (toshi1127) #26810

Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

header explicit usage, order, and reduce use of *-inl.h
pointer -> const reference when possible
no variable recyclicng
std::begin/end prefered over instance.begin/end
USE for explicit unused resaults

Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

PR-URL: #26476 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Richard Lau riclau@uk.ibm.com

Refactor the C++ class to be resuable for other types of profiles
Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors.
Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results.
Renames lib/internal/coverage-gen/with_profiler.js to lib/internal/profiler.js because it is now the only way to generate coverage.

PR-URL: #26513 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ben Coe bencoe@gmail.com

Since these depends on process runtime states, delay them until pre-execution.

PR-URL: #26517 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

Shim legacy process object properties of CLI options during pre-execution instead of serializing them during bootstrap.

PR-URL: #26517 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

Backport-PR-URL: #26650 PR-URL: #26548 Refs: #26546 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

PR-URL: #26493 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Use a RAII approach by default, and make it possible for embedders to use the ArrayBufferAllocator directly as a V8 ArrayBuffer::Allocator, e.g. when passing to Isolate::CreateParams manually.

PR-URL: #26525 Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

Split the API up into its essential parts, namely setting up the creation parameters for the Isolate, creating it, and performing Node.js-specific customization afterwards.

PR-URL: #26525 Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

Instead of patching process._breakFirstLine to inform the JS land to wait for the debugger, check that the JS land has not yet serialized the options and then patch the debug options from C++. The changes will be carried into JS later during option serialization.

PR-URL: #26602 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Eugene Ostroukhov eostroukhov@google.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

PR-URL: #23081 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Sakthipriyan Vairamani thechargingvolcano@gmail.com Reviewed-By: Weijia Wang starkwang@126.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Denys Otrishko shishugi@gmail.com Reviewed-By: John-David Dalton john.david.dalton@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net

PR-URL: #26769 Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

PR-URL: #26810 Refs: #26546 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

Another nail in the coffin here, farewell ye ol C-style apis.

These apis caused numerous other issues that required far too many safeguards. This gets us one step closer to not having to worry about those issues anymore.

Refs: #18066 Refs: #20298

PR-URL: #26760

Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

PR-URL: #26814 Refs: #26546 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

PR-URL: #26783 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

Instead of relying on the value of the CLI option when executing bootstrap/loaders.js.

PR-URL: #26759 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

In the current code, line 497 checks if item is null or undefined. However, item is guaranteed to be a non-null object or function at that point.

Lines 484/485 set primitive to true if item is null or undefined.
Line 486 skips line 497 if primitive is true (which it will always be if item is null or undefined) and properties is undefined. So the only way to get to line 497 when item is null or undefined is if properties is specified.
Line 494 skips line 497 if primitive is true (which it will always be if item is null or undefined) and properties are specified (which will always be the case or else this else block is skipped.)

Here are the current lines 484 through 497:

  const primitive = item === null ||
      (typeof item !== 'function' && typeof item !== 'object');
  if (properties === undefined && primitive) {
    hasPrimitives = true;
    valuesKeyArray[i] = _inspect(item);
  } else {
    const keys = properties || ObjectKeys(item);
    for (const key of keys) {
      if (map[key] === undefined)
        map[key] = [];
      if ((primitive && properties) || !hasOwnProperty(item, key))
        map[key][i] = '';
      else
        map[key][i] = item == null ? item : _inspect(item[key]);

This change removes the unnecessary ternary in that final line, simplifying it to:

        map[key][i] = _inspect(item[key]);

PR-URL: #26906 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: Yuta Hiroto hello@hiroppy.me Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Tobias Nießen tniessen@tnie.de

PR-URL: #26815 Reviewed-By: Refael Ackermann refack@gmail.com

Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module.

PR-URL: #26912 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com

This fixes the parse function for single character input that are not a path separator.

PR-URL: #26912 Fixes: #26911 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #26591 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

When console.log is called for the first time it initializes TTYWrap object. However, if there is not enough space on the V8 stack, creating function template fails and triggers empty maybe local exception.

PR-URL: #26832 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

PR-URL: #27041 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

Cleanup some code and make the emit hooks very slightly faster.

PR-URL: #27034 Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

It was reported that parallel builds on Windows sometimes error because of missing intermediate files.

On closer inspection I noticed that some files are copied from src/ to the intermediate build directory in a way where they don't participate in dependency resolution. Put another way, the build system doesn't know to wait for the copy to complete because we don't tell it to.

Fix that by not copying around files but instead making the script that processes them a little smarter about where to find them and where to store the results.

PR-URL: #27026 Fixes: #27025 Reviewed-By: Eugene Ostroukhov eostroukhov@google.com Reviewed-By: Richard Lau riclau@uk.ibm.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

PR-URL: #27041 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

Refs: #26982

PR-URL: #27164 Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

BethGriggs added a commit that referenced this pull request

Apr 10, 2019

Notable changes:

child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
dns:
- make dns.promises enumerable (cjihrig) #26592
- remove dns.promises experimental warning (cjihrig) #26592
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

spawn-wrap has come up before. I am not sure anymore if it always comes up for 11 or if it's flaky.

citgm.leveldown-v5.0.1
npm ERR! C:\Program Files\Git\mingw64/libexec/git-core\git-submodule: line 19: .: git-sh-setup: file not found
Git setup issue? @nodejs/build

Looks very very strange... I keep getting git timeouts, so this might be a network issue...

I imagine (SEMVER-MINOR) fs: remove experimental warning for fs.promises (Anna Henningsen) #26581 might be something to add to the Notable changes section.

Notable changes:

child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
dns:
- make dns.promises enumerable (cjihrig) #26592
- remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581)
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

BethGriggs added a commit that referenced this pull request

Apr 11, 2019

BethGriggs added a commit that referenced this pull request

Apr 11, 2019

Notable changes:

child_process: doc deprecate ChildProcess._channel (cjihrig) #26982
deps: update nghttp2 to 1.37.0 (gengjiawen) #26990
dns:
- make dns.promises enumerable (cjihrig) #26592
- remove dns.promises experimental warning (cjihrig) #26592
fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581)
stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989
worker: use copy of process.env (Anna Henningsen) #26544

PR-URL: #27163

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request

Apr 11, 2019

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request

Apr 11, 2019

targos deleted the v11.14.0-proposal branch

June 4, 2019 14:09