deps: update ICU to 64.2 by ryzokuken · Pull Request #27361 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation20 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Release Date: April 17th

Fixes: #26388

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

/cc @srl295 @refack @targos 🎉

NOTE: This is required to make V8's canary work with Node.js again.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated license changes, please investigate.

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35)

Fixes: nodejs#26388

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second commit LGTM.

RSLGTM for the first commit.

@@ -114,12 +114,12 @@ The externally maintained libraries used by Node.js are:
IN THE SOFTWARE.
"""

- ICU, located at deps/icu-small, is licensed as follows:
- ICU, located at deps/icu, is licensed as follows:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ICU, located at deps/icu, is licensed as follows:
- ICU, located at deps/icu-small, is licensed as follows:

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2

Great for doing this! Didn’t review yet ^ if you “make clean” and rerun the license gen it should change the license file to Be consistent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks Great To Me!

srl295 added the i18n-api

Issues and PRs related to the i18n implementation.

label

Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

Oh also, this is needed for Japanese Era (Reiwa) support

$ ./node -p "new Date('5/1/2019').toLocaleString('ja-u-ca-japanese', {era: 'long'})"
令和元年5月1日 0:00:00

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 24, 2019

Landed in 6bbb9eb...c80c414

targos pushed a commit that referenced this pull request

Apr 25, 2019

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

targos pushed a commit that referenced this pull request

Apr 25, 2019

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2

PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

targos pushed a commit that referenced this pull request

Apr 27, 2019

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

targos pushed a commit that referenced this pull request

Apr 27, 2019

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2

PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

targos added a commit that referenced this pull request

Apr 27, 2019

Notable changes:

intl:
- Update ICU to 64.2. This adds support for Japanese Era (Reiwa). #27361
- Fixes a bug in ICU that affected Node.js 12.0.0 in the case where new Date().toLocaleString() was called with a non-default locale. #27415
C++ API:
- Added an Environment overload of EmitAsyncDestroy. #27255

PR-URL: TODO

targos added a commit that referenced this pull request

Apr 29, 2019

Notable changes:

intl:
- Update ICU to 64.2. This adds support for Japanese Era (Reiwa). #27361
- Fixes a bug in ICU that affected Node.js 12.0.0 in the case where new Date().toLocaleString() was called with a non-default locale. #27415
C++ API:
- Added an overload of EmitAsyncDestroy that can be used during garbage collection. #27255

PR-URL: #27440

targos added a commit that referenced this pull request

Apr 29, 2019

Notable changes:

intl:
- Update ICU to 64.2. This adds support for Japanese Era (Reiwa). #27361
- Fixes a bug in ICU that affected Node.js 12.0.0 in the case where new Date().toLocaleString() was called with a non-default locale. #27415
C++ API:
- Added an overload of EmitAsyncDestroy that can be used during garbage collection. #27255

PR-URL: #27440

Yes, great work @ryzokuken and reviewers! Happy to see this landed before Reiwa starts.

BethGriggs pushed a commit that referenced this pull request

May 10, 2019

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

BethGriggs pushed a commit that referenced this pull request

May 10, 2019

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2

PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

MylesBorins pushed a commit that referenced this pull request

May 16, 2019

Update the version of the bundled ICU (deps/icu-small) to ICU version 64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

MylesBorins pushed a commit that referenced this pull request

May 16, 2019

Update the LICENSE file and tools/icu/current_ver.dep file in order to finalize the upgrade to ICU 64.2

PR-URL: #27361 Fixes: #26388 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

BethGriggs added a commit that referenced this pull request

May 28, 2019

Notable changes:

deps:
- update ICU to 64.2 (Ujjwal Sharma) #27361
- upgrade npm to 6.9.0 (Kat Marchán) #26244
- upgrade openssl sources to 1.1.1b (Sam Roberts) #26327
- upgrade to libuv 1.28.0 (cjihrig) #27241
events:
- add once method to use promises with EventEmitter (Matteo Collina) #26078
n-api:
- mark thread-safe function as stable (Gabriel Schulhof) #25556
repl:
- support top-level for-await-of (Shelley Vohr) #23841
zlib:
- add brotli support (Anna Henningsen) #24938

PR-URL: #27514

BethGriggs added a commit that referenced this pull request

May 28, 2019

Notable changes:

deps:
- update ICU to 64.2 (Ujjwal Sharma) #27361
- upgrade npm to 6.9.0 (Kat Marchán) #26244
- upgrade openssl sources to 1.1.1b (Sam Roberts) #26327
- upgrade to libuv 1.28.0 (cjihrig) #27241
events:
- add once method to use promises with EventEmitter (Matteo Collina) #26078
n-api:
- mark thread-safe function as stable (Gabriel Schulhof) #25556
repl:
- support top-level for-await-of (Shelley Vohr) #23841
zlib:
- add brotli support (Anna Henningsen) #24938

PR-URL: #27514

This was referenced

May 29, 2019

Reviewers

srl295 srl295 approved these changes

targos targos left review comments

richardlau richardlau approved these changes

mhdawson mhdawson approved these changes

refack Awaiting requested review from refack

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

i18n-api

Issues and PRs related to the i18n implementation.