Remove unnecessary #![feature(min_specialization)] by Zalathar · Pull Request #120866 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
As of #119963 and #120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.
Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.
r? @TaKO8Ki
rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
cc @clubby789
Looks like newtype_index! still requires crate-wide min_specialization in some cases, in order for the macro to implement TrustedStep as part of #[orderable].
r? compiler-errors @bors r+ rollup
📌 Commit cf1096e has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
I've filed #120870 to address the remaining cases.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…rrors
Remove unnecessary #![feature(min_specialization)]
As of rust-lang#119963 and rust-lang#120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.
Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]
This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.
We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].
This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…rrors
Remove unnecessary #![feature(min_specialization)]
As of rust-lang#119963 and rust-lang#120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.
Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]
This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.
We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].
This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#117614 (static mut: allow mutable reference to arbitrary types, not just slices and arrays)
- rust-lang#120588 (wasm: Store rlib metadata in wasm object files)
- rust-lang#120719 (Remove support for
associated_type_boundnested indyntypes) - rust-lang#120823 (Clarify that atomic and regular integers can differ in alignment)
- rust-lang#120859 (Loosen an assertion to account for stashed errors.)
- rust-lang#120865 (Turn the "no saved object file in work product" ICE into a translatable fatal error)
- rust-lang#120866 (Remove unnecessary
#![feature(min_specialization)]) - rust-lang#120870 (Allow restricted trait impls under
#[allow_internal_unstable(min_specialization)])
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]
This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.
We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].
This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#117614 (static mut: allow mutable reference to arbitrary types, not just slices and arrays)
- rust-lang#120719 (Remove support for
associated_type_boundnested indyntypes) - rust-lang#120764 (Add documentation on
str::starts_with) - rust-lang#120823 (Clarify that atomic and regular integers can differ in alignment)
- rust-lang#120859 (Loosen an assertion to account for stashed errors.)
- rust-lang#120865 (Turn the "no saved object file in work product" ICE into a translatable fatal error)
- rust-lang#120866 (Remove unnecessary
#![feature(min_specialization)]) - rust-lang#120870 (Allow restricted trait impls under
#[allow_internal_unstable(min_specialization)])
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#120870 - Zalathar:allow-min-spec, r=oli-obk
Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]
This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.
We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].
This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#120866 - Zalathar:no-min-spec, r=compiler-errors
Remove unnecessary #![feature(min_specialization)]
As of rust-lang#119963 and rust-lang#120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.
Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.