Loosen an assertion to account for stashed errors. by nnethercote · Pull Request #120859 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The meaning of this assertion changed in #120828 when the meaning of has_errors changed to exclude stashed errors. Evidently the new meaning is too restrictive.
Fixes #120856.
r? @oli-obk
The meaning of this assertion changed in rust-lang#120828 when the meaning of
has_errors changed to exclude stashed errors. Evidently the new
meaning is too restrictive.
Fixes rust-lang#120856.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit bb60ded has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Loosen an assertion to account for stashed errors.
The meaning of this assertion changed in rust-lang#120828 when the meaning of has_errors changed to exclude stashed errors. Evidently the new meaning is too restrictive.
Fixes rust-lang#120856.
r? @oli-obk
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Loosen an assertion to account for stashed errors.
The meaning of this assertion changed in rust-lang#120828 when the meaning of has_errors changed to exclude stashed errors. Evidently the new meaning is too restrictive.
Fixes rust-lang#120856.
r? @oli-obk
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#117614 (static mut: allow mutable reference to arbitrary types, not just slices and arrays)
- rust-lang#120588 (wasm: Store rlib metadata in wasm object files)
- rust-lang#120719 (Remove support for
associated_type_boundnested indyntypes) - rust-lang#120823 (Clarify that atomic and regular integers can differ in alignment)
- rust-lang#120859 (Loosen an assertion to account for stashed errors.)
- rust-lang#120865 (Turn the "no saved object file in work product" ICE into a translatable fatal error)
- rust-lang#120866 (Remove unnecessary
#![feature(min_specialization)]) - rust-lang#120870 (Allow restricted trait impls under
#[allow_internal_unstable(min_specialization)])
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#117614 (static mut: allow mutable reference to arbitrary types, not just slices and arrays)
- rust-lang#120719 (Remove support for
associated_type_boundnested indyntypes) - rust-lang#120764 (Add documentation on
str::starts_with) - rust-lang#120823 (Clarify that atomic and regular integers can differ in alignment)
- rust-lang#120859 (Loosen an assertion to account for stashed errors.)
- rust-lang#120865 (Turn the "no saved object file in work product" ICE into a translatable fatal error)
- rust-lang#120866 (Remove unnecessary
#![feature(min_specialization)]) - rust-lang#120870 (Allow restricted trait impls under
#[allow_internal_unstable(min_specialization)])
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#120859 - nnethercote:fix-120856, r=oli-obk
Loosen an assertion to account for stashed errors.
The meaning of this assertion changed in rust-lang#120828 when the meaning of has_errors changed to exclude stashed errors. Evidently the new meaning is too restrictive.
Fixes rust-lang#120856.
r? @oli-obk
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.