Turn the "no saved object file in work product" ICE into a translatable fatal error by saethlin · Pull Request #120865 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I don't know if it's fair to say this fixes #120854 but it surely makes the error reporting better and should encourage people with good instincts like @CinchBlue.
r? @nnethercote
rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
| @@ -913,7 +913,9 @@ fn execute_copy_from_cache_work_item<B: ExtraBackendMethods>( |
|---|
| let object = load_from_incr_comp_dir( |
| cgcx.output_filenames.temp_path(OutputType::Object, Some(&module.name)), |
| module.source.saved_files.get("o").expect("no saved object file in work product"), |
| module.source.saved_files.get("o").unwrap_or_else(| |
| cgcx.create_dcx().emit_fatal(errors::NoSavedObjectFile { cgu_name: &module.name }) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "CGU" the rustc term for what LLVM calls a "module"? I'm trying to understand the cgu_name/module.name inconsistency here.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that's what's going on here. I decided to call this a CGU name based on how CachedModuleCodegen are created:
| CachedModuleCodegen { |
|---|
| name: cgu.name().to_string(), |
| source: cgu.previous_work_product(tcx), |
| }, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
📌 Commit 3d4a9f5 has been approved by nnethercote
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…rcote
Turn the "no saved object file in work product" ICE into a translatable fatal error
I don't know if it's fair to say this fixes rust-lang#120854 but it surely makes the error reporting better and should encourage people with good instincts like @CinchBlue.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…rcote
Turn the "no saved object file in work product" ICE into a translatable fatal error
I don't know if it's fair to say this fixes rust-lang#120854 but it surely makes the error reporting better and should encourage people with good instincts like @CinchBlue.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#117614 (static mut: allow mutable reference to arbitrary types, not just slices and arrays)
- rust-lang#120588 (wasm: Store rlib metadata in wasm object files)
- rust-lang#120719 (Remove support for
associated_type_boundnested indyntypes) - rust-lang#120823 (Clarify that atomic and regular integers can differ in alignment)
- rust-lang#120859 (Loosen an assertion to account for stashed errors.)
- rust-lang#120865 (Turn the "no saved object file in work product" ICE into a translatable fatal error)
- rust-lang#120866 (Remove unnecessary
#![feature(min_specialization)]) - rust-lang#120870 (Allow restricted trait impls under
#[allow_internal_unstable(min_specialization)])
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#117614 (static mut: allow mutable reference to arbitrary types, not just slices and arrays)
- rust-lang#120719 (Remove support for
associated_type_boundnested indyntypes) - rust-lang#120764 (Add documentation on
str::starts_with) - rust-lang#120823 (Clarify that atomic and regular integers can differ in alignment)
- rust-lang#120859 (Loosen an assertion to account for stashed errors.)
- rust-lang#120865 (Turn the "no saved object file in work product" ICE into a translatable fatal error)
- rust-lang#120866 (Remove unnecessary
#![feature(min_specialization)]) - rust-lang#120870 (Allow restricted trait impls under
#[allow_internal_unstable(min_specialization)])
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#120865 - saethlin:missing-o-files, r=nnethercote
Turn the "no saved object file in work product" ICE into a translatable fatal error
I don't know if it's fair to say this fixes rust-lang#120854 but it surely makes the error reporting better and should encourage people with good instincts like @CinchBlue.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.