Various rustc_codegen_ssa cleanups by bjorn3 · Pull Request #123237 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits8 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 30, 2024

Comment on lines +35 to +37

if pointee.dyncast_vector().is_some() {
panic!()
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be an assert!()?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just moving some code around.

This comment has been minimized.

It is only implemented for a single type. Directly passing this type is simpler and avoids overhead from indirect calls.

It can be retrieved from the Session too.

They are not representable by Cranelift

r? compiler-errors @bors r+

📌 Commit 84f45bb has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 27, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 27, 2024

…ler-errors

Various rustc_codegen_ssa cleanups

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 27, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 27, 2024

…ler-errors

Various rustc_codegen_ssa cleanups

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 27, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 28, 2024

…ler-errors

Various rustc_codegen_ssa cleanups

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

Any chance this could have failed the rollup with #127066 (comment)? That same error happened in another rollup too. Seems unlikely, but nothing else seems more likely

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

The failing test seems to be

// foo.rs

// This is kept because of #[used]: #[used] static FOO: u32 = 0;

// This is removable because it is unused: #[allow(dead_code)] static BAR: u32 = 0;

// This is kept because it is publicly reachable: pub static BAZ: u32 = 0;

// This is kept because it is referenced by a public, reachable function: static QUUX: u32 = 0;

pub fn quux() -> &'static u32 { &QUUX }

// This is removable because it is referenced by a private, unused (dead) function: static CORGE: u32 = 0;

#[allow(dead_code)] fn corge() -> &'static u32 { &CORGE }

Maybe #127052 is related given that this uses #[used]?

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 29, 2024

…ler-errors

Various rustc_codegen_ssa cleanups

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#123237 (Various rustc_codegen_ssa cleanups)
rust-lang#126960 (Improve error message in tidy)
rust-lang#127002 (Implement x perf as a separate tool)
rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit)
rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel)
rust-lang#127106 (Improve unsafe extern blocks diagnostics)
rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.)
rust-lang#127114 (fix: prefer (*p).clone to p.clone if the p is a raw pointer)
rust-lang#127118 (Show used attribute's kind for user when find it isn't applied to a static variable.)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#123237 (Various rustc_codegen_ssa cleanups)
rust-lang#126960 (Improve error message in tidy)
rust-lang#127002 (Implement x perf as a separate tool)
rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel)
rust-lang#127106 (Improve unsafe extern blocks diagnostics)
rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.)
rust-lang#127114 (fix: prefer (*p).clone to p.clone if the p is a raw pointer)
rust-lang#127118 (Show used attribute's kind for user when find it isn't applied to a static variable.)
rust-lang#127122 (Remove uneccessary condition in div_ceil)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 30, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#123237 (Various rustc_codegen_ssa cleanups)
rust-lang#126960 (Improve error message in tidy)
rust-lang#127002 (Implement x perf as a separate tool)
rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel)
rust-lang#127106 (Improve unsafe extern blocks diagnostics)
rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.)
rust-lang#127114 (fix: prefer (*p).clone to p.clone if the p is a raw pointer)
rust-lang#127118 (Show used attribute's kind for user when find it isn't applied to a static variable.)
rust-lang#127122 (Remove uneccessary condition in div_ceil)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 30, 2024

Rollup merge of rust-lang#123237 - bjorn3:debuginfo_refactor, r=compiler-errors

Various rustc_codegen_ssa cleanups

bjorn3 deleted the debuginfo_refactor branch

June 30, 2024 10:34

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.