Implement x perf as a separate tool by Kobzol · Pull Request #127002 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation14 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Continues work from #126318, adds a CLI for running rustc-perf profiling commands through a new rustc-perf-wrapper tool. The CLI is in a separate tool to enable experimentation outside of bootstrap.

This is probably most of what we can do so far, I'll add support for benchmarking once rustc-perf gets a terminal output for comparing benchmark results.

r? @onur-ozkan

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jun 26, 2024

This comment has been minimized.

Kobzol marked this pull request as ready for review

June 27, 2024 08:28

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link wrapper tool's path to bootstrap team in triagebot file?

rustbot added the A-meta

Area: Issues & PRs about the rust-lang/rust repository itself

label

Jun 29, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

Modified triagebot.toml and resolved comments (hopefully :) ).

📌 Commit 6a2638e has been approved by onur-ozkan

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 29, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 29, 2024

…-ozkan

Implement x perf as a separate tool

Continues work from rust-lang#126318, adds a CLI for running rustc-perf profiling commands through a new rustc-perf-wrapper tool. The CLI is in a separate tool to enable experimentation outside of bootstrap.

This is probably most of what we can do so far, I'll add support for benchmarking once rustc-perf gets a terminal output for comparing benchmark results.

r? @onur-ozkan

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#123237 (Various rustc_codegen_ssa cleanups)
• rust-lang#126960 (Improve error message in tidy)
• rust-lang#127002 (Implement x perf as a separate tool)
• rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit)
• rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel)
• rust-lang#127106 (Improve unsafe extern blocks diagnostics)
• rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.)
• rust-lang#127114 (fix: prefer (*p).clone to p.clone if the p is a raw pointer)
• rust-lang#127118 (Show used attribute's kind for user when find it isn't applied to a static variable.)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#123237 (Various rustc_codegen_ssa cleanups)
• rust-lang#126960 (Improve error message in tidy)
• rust-lang#127002 (Implement x perf as a separate tool)
• rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel)
• rust-lang#127106 (Improve unsafe extern blocks diagnostics)
• rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.)
• rust-lang#127114 (fix: prefer (*p).clone to p.clone if the p is a raw pointer)
• rust-lang#127118 (Show used attribute's kind for user when find it isn't applied to a static variable.)
• rust-lang#127122 (Remove uneccessary condition in div_ceil)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 30, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#123237 (Various rustc_codegen_ssa cleanups)
• rust-lang#126960 (Improve error message in tidy)
• rust-lang#127002 (Implement x perf as a separate tool)
• rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel)
• rust-lang#127106 (Improve unsafe extern blocks diagnostics)
• rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.)
• rust-lang#127114 (fix: prefer (*p).clone to p.clone if the p is a raw pointer)
• rust-lang#127118 (Show used attribute's kind for user when find it isn't applied to a static variable.)
• rust-lang#127122 (Remove uneccessary condition in div_ceil)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 30, 2024

Rollup merge of rust-lang#127002 - Kobzol:bootstrap-perf-tool, r=onur-ozkan

Implement x perf as a separate tool

Continues work from rust-lang#126318, adds a CLI for running rustc-perf profiling commands through a new rustc-perf-wrapper tool. The CLI is in a separate tool to enable experimentation outside of bootstrap.

This is probably most of what we can do so far, I'll add support for benchmarking once rustc-perf gets a terminal output for comparing benchmark results.

r? @onur-ozkan

Kobzol deleted the bootstrap-perf-tool branch

June 30, 2024 05:18

Labels

A-meta

Area: Issues & PRs about the rust-lang/rust repository itself

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)