Fix a error suggestion for E0121 when using placeholder _ as return types on function signature. by surechen · Pull Request #127110 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

surechen

Recommit after refactoring based on comment:
#126017 (comment)

But when changing return type's lifetime to ReError will affect the subsequent borrow check process and cause test11 in typeck_type_placeholder_item.rs to lost E0515 message.

fn test11(x: &usize) -> &_ { //^ ERROR the placeholder _ is not allowed within types on item signatures for return types &x // ERROR cannot return reference to function parameter(this E0515 msg will disappear) }

fixes #125488

r? @pnkfelix

@surechen

…ypes on function signature.

Recommit after refactoring based on comment: rust-lang#126017 (comment)

But when changing return type's lifetime to ReError will affect the subsequent borrow check process and cause test11 in typeck_type_placeholder_item.rs to lost E0515 message.

fn test11(x: &usize) -> &_ {
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types
    &x //~ ERROR cannot return reference to function parameter(this E0515 msg will disappear)
}

@rustbot

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 29, 2024

@surechen surechen changed the titleFix a error suggestion for E0121 when using placeholder _ as return t… Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.

Jun 29, 2024

compiler-errors

@compiler-errors

Thanks for applying the suggestion.

@bors r+

@bors

📌 Commit 50edb32 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 29, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 29, 2024

@matthiaskrgr

…-errors

Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.

Recommit after refactoring based on comment: rust-lang#126017 (comment)

But when changing return type's lifetime to ReError will affect the subsequent borrow check process and cause test11 in typeck_type_placeholder_item.rs to lost E0515 message.

fn test11(x: &usize) -> &_ {
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types
    &x //~ ERROR cannot return reference to function parameter(this E0515 msg will disappear)
}

fixes rust-lang#125488

r? @pnkfelix

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

@bors

…iaskrgr

Rollup of 9 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

@bors

…iaskrgr

Rollup of 9 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 30, 2024

@bors

…iaskrgr

Rollup of 9 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 30, 2024

@rust-timer

Rollup merge of rust-lang#127110 - surechen:fix_125488_06, r=compiler-errors

Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.

Recommit after refactoring based on comment: rust-lang#126017 (comment)

But when changing return type's lifetime to ReError will affect the subsequent borrow check process and cause test11 in typeck_type_placeholder_item.rs to lost E0515 message.

fn test11(x: &usize) -> &_ {
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types
    &x //~ ERROR cannot return reference to function parameter(this E0515 msg will disappear)
}

fixes rust-lang#125488

r? @pnkfelix

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.