Port repr128-dwarf run-make test to rmake by beetrees · Pull Request #124280 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation14 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This PR ports the repr128-dwarf run-make test to rmake, using the gimli crate instead of the llvm-dwarfdump command.

Note that this PR changes rmake.rs files to be compiled with the 2021 edition (previously no edition was passed to rustc, meaning they were compiled with the 2015 edition). This means that panic!("{variable}") will now work as expected in rmake.rs files (there's already a usage in the wasm-symbols-not-exported test that this will fix).

Tracking issue: #121876

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Apr 23, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in run-make tests.

cc @jieyouxu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me in general, only thing is I'm not 100% sure if we want to make every rmake.rs be edition 2021 by default. I think we can experiment with edition 2021 by default, and revert / check that individual rmake.rs can override with //@ edition: 2015 if for some reason an earlier edition is required.

@@ -3824,6 +3824,7 @@ impl<'test> TestCx<'test> {
.arg(format!("-Ldependency={}", &support_lib_deps_deps.to_string_lossy()))
.arg("--extern")
.arg(format!("run_make_support={}", &support_lib_path.to_string_lossy()))
.arg("--edition=2021")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do we want to force edition 2021 for every rmake test?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not. The rmake test files are “developer-facing” after all unlike the Rust files found in e.g. tests/ui. They are test runners, not “test subjects”. Lol, lacking the proper words rn. Similarly, compiler/ / rustc_* crates all default to Rust 2021.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense yeah, I was just wondering if where was any weird edge cases I have not considered

Thanks for the PR!

@bors r+

📌 Commit 8c64a56 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 23, 2024

fmease added a commit to fmease/rust that referenced this pull request

Apr 24, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 24, 2024

Rollup of 6 pull requests

Successful merges:

rust-lang#122500 (delegation: Support renaming, and async, const, extern "ABI" and C-variadic functions)
rust-lang#123316 (Test #[unix_sigpipe = "inherit"] with both SIG_DFL and SIG_IGN)
rust-lang#124136 (Provide more context and suggestions in borrowck errors involving closures)
rust-lang#124280 (Port repr128-dwarf run-make test to rmake)
rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
rust-lang#124308 (Add diagnostic item for std::iter::Enumerate)