windows fill_utf16_buf: explain the expected return value by RalfJung · Pull Request #124282 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks12 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The comment just says "return what the syscall returns", but that doesn't work for all syscalls as the Windows API is not consistent in how buffer size is negotiated. For instance, GetUserProfileDirectoryW works a bit differently, and so home_dir_crt has to translate this to the usual protocol itself. So it's worth describing that protocol.
r? @ChrisDenton
Operating system: Windows
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Makes sense to me.
@bors r+ rollup
📌 Commit a21c2d8 has been approved by ChrisDenton
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
fmease added a commit to fmease/rust that referenced this pull request
…nton
windows fill_utf16_buf: explain the expected return value
The comment just says "return what the syscall returns", but that doesn't work for all syscalls as the Windows API is not consistent in how buffer size is negotiated. For instance, GetUserProfileDirectoryW works a bit differently, and so home_dir_crt has to translate this to the usual protocol itself. So it's worth describing that protocol.
r? @ChrisDenton
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#122500 (delegation: Support renaming, and async, const, extern "ABI" and C-variadic functions)
- rust-lang#123316 (Test
#[unix_sigpipe = "inherit"]with bothSIG_DFLandSIG_IGN) - rust-lang#124136 (Provide more context and suggestions in borrowck errors involving closures)
- rust-lang#124280 (Port repr128-dwarf run-make test to rmake)
- rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
- rust-lang#124308 (Add diagnostic item for
std::iter::Enumerate)
r? @ghost
@rustbot modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request
…nton
windows fill_utf16_buf: explain the expected return value
The comment just says "return what the syscall returns", but that doesn't work for all syscalls as the Windows API is not consistent in how buffer size is negotiated. For instance, GetUserProfileDirectoryW works a bit differently, and so home_dir_crt has to translate this to the usual protocol itself. So it's worth describing that protocol.
r? @ChrisDenton
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- rust-lang#122500 (delegation: Support renaming, and async, const, extern "ABI" and C-variadic functions)
- rust-lang#123316 (Test
#[unix_sigpipe = "inherit"]with bothSIG_DFLandSIG_IGN) - rust-lang#123794 (More DefineOpaqueTypes::Yes)
- rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
- rust-lang#124308 (Add diagnostic item for
std::iter::Enumerate)
Failed merges:
- rust-lang#124136 (Provide more context and suggestions in borrowck errors involving closures)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#124282 - RalfJung:fill_utf16_buf, r=ChrisDenton
windows fill_utf16_buf: explain the expected return value
The comment just says "return what the syscall returns", but that doesn't work for all syscalls as the Windows API is not consistent in how buffer size is negotiated. For instance, GetUserProfileDirectoryW works a bit differently, and so home_dir_crt has to translate this to the usual protocol itself. So it's worth describing that protocol.
r? @ChrisDenton
Labels
Operating system: Windows
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.