Add diagnostic item for std::iter::Enumerate by CBSpeir · Pull Request #124308 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks12 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This adds a diagnostic item for std::iter::Enumerate. The change will be used by the clippy unused_enumerate_index lint to move away from type paths to using diagnostic items.
see: rust-lang/rust-clippy#5393
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
labels
📌 Commit bcc4469 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
fmease added a commit to fmease/rust that referenced this pull request
… r=compiler-errors
Add diagnostic item for std::iter::Enumerate
This adds a diagnostic item for std::iter::Enumerate. The change will be used by the clippy unused_enumerate_index lint to move away from type paths to using diagnostic items.
see: rust-lang/rust-clippy#5393
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#122500 (delegation: Support renaming, and async, const, extern "ABI" and C-variadic functions)
- rust-lang#123316 (Test
#[unix_sigpipe = "inherit"]with bothSIG_DFLandSIG_IGN) - rust-lang#124136 (Provide more context and suggestions in borrowck errors involving closures)
- rust-lang#124280 (Port repr128-dwarf run-make test to rmake)
- rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
- rust-lang#124308 (Add diagnostic item for
std::iter::Enumerate)
r? @ghost
@rustbot modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request
… r=compiler-errors
Add diagnostic item for std::iter::Enumerate
This adds a diagnostic item for std::iter::Enumerate. The change will be used by the clippy unused_enumerate_index lint to move away from type paths to using diagnostic items.
see: rust-lang/rust-clippy#5393
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- rust-lang#122500 (delegation: Support renaming, and async, const, extern "ABI" and C-variadic functions)
- rust-lang#123316 (Test
#[unix_sigpipe = "inherit"]with bothSIG_DFLandSIG_IGN) - rust-lang#123794 (More DefineOpaqueTypes::Yes)
- rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
- rust-lang#124308 (Add diagnostic item for
std::iter::Enumerate)
Failed merges:
- rust-lang#124136 (Provide more context and suggestions in borrowck errors involving closures)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#124308 - CBSpeir:diagnostic-item-enumerate, r=compiler-errors
Add diagnostic item for std::iter::Enumerate
This adds a diagnostic item for std::iter::Enumerate. The change will be used by the clippy unused_enumerate_index lint to move away from type paths to using diagnostic items.
see: rust-lang/rust-clippy#5393
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…method, r=scottmcm
Add diagnostic item for std::iter::Iterator::enumerate
Adds a diagnostic item for the std::iter:Iterator::enumerate trait method. This change, along with PR rust-lang#124308, will be used by the clippy unused_enumerate_index lint to move away from paths to using diagnostic items.
see: rust-lang/rust-clippy#5393
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…method, r=scottmcm
Add diagnostic item for std::iter::Iterator::enumerate
Adds a diagnostic item for the std::iter:Iterator::enumerate trait method. This change, along with PR rust-lang#124308, will be used by the clippy unused_enumerate_index lint to move away from paths to using diagnostic items.
see: rust-lang/rust-clippy#5393
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#124542 - CBSpeir:diagnostic-item-enumerate-method, r=scottmcm
Add diagnostic item for std::iter::Iterator::enumerate
Adds a diagnostic item for the std::iter:Iterator::enumerate trait method. This change, along with PR rust-lang#124308, will be used by the clippy unused_enumerate_index lint to move away from paths to using diagnostic items.
see: rust-lang/rust-clippy#5393
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.