Cleanup: Fix up some diagnostics by fmease · Pull Request #125210 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks12 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Several diagnostics contained their error code inside their primary message which is no bueno.
This PR moves them out of the message and turns them into structured error codes.

Also fixes another occurrence of -> after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in #104345 (2022) but didn't update all instances as I've noted here: #104345 (comment) (“the future is now!”).

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

May 17, 2024

fmease added the C-cleanup

Category: PRs that clean code up or issues documenting cleanup.

label

May 17, 2024

fmease added S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 21, 2024

fmease added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

labels

May 22, 2024

rebased
@bors r=davidtwco rollup

📌 Commit ae49dbe has been approved by davidtwco

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 22, 2024

fmease added a commit to fmease/rust that referenced this pull request

May 22, 2024

Cleanup: Fix up some diagnostics

Several diagnostics contained their error code inside their primary message which is no bueno. This PR moves them out of the message and turns them into structured error codes.

Also fixes another occurrence of -> after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in rust-lang#104345 (2022) but didn't update all instances as I've noted here: rust-lang#104345 (comment) (“the future is now!”).

fmease added a commit to fmease/rust that referenced this pull request

May 22, 2024

Cleanup: Fix up some diagnostics

Several diagnostics contained their error code inside their primary message which is no bueno. This PR moves them out of the message and turns them into structured error codes.

Also fixes another occurrence of -> after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in rust-lang#104345 (2022) but didn't update all instances as I've noted here: rust-lang#104345 (comment) (“the future is now!”).

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 22, 2024

Rollup of 7 pull requests

Successful merges:

• rust-lang#122665 (Add some tests for public-private dependencies.)
• rust-lang#125210 (Cleanup: Fix up some diagnostics)
• rust-lang#125316 (Tweak Spacing use)
• rust-lang#125401 (Migrate run-make/rustdoc-scrape-examples-macros to rmake.rs)
• rust-lang#125406 (Directly add extension instead of using Path::with_extension)
• rust-lang#125409 (Rename FrameworkOnlyWindows to RawDylibOnlyWindows)
• rust-lang#125416 (Use correct param-env in MissingCopyImplementations)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024

Rollup of 7 pull requests

Successful merges:

• rust-lang#122665 (Add some tests for public-private dependencies.)
• rust-lang#125210 (Cleanup: Fix up some diagnostics)
• rust-lang#125316 (Tweak Spacing use)
• rust-lang#125401 (Migrate run-make/rustdoc-scrape-examples-macros to rmake.rs)
• rust-lang#125406 (Directly add extension instead of using Path::with_extension)
• rust-lang#125409 (Rename FrameworkOnlyWindows to RawDylibOnlyWindows)
• rust-lang#125416 (Use correct param-env in MissingCopyImplementations)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 23, 2024

Cleanup: Fix up some diagnostics

Several diagnostics contained their error code inside their primary message which is no bueno. This PR moves them out of the message and turns them into structured error codes.

Also fixes another occurrence of -> after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in rust-lang#104345 (2022) but didn't update all instances as I've noted here: rust-lang#104345 (comment) (“the future is now!”).

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#125165 (Migrate run-make/pgo-branch-weights to rmake)
• rust-lang#125210 (Cleanup: Fix up some diagnostics)
• rust-lang#125224 (Migrate run-make/issue-53964 to rmake)
• rust-lang#125227 (Migrate run-make/issue-30063 to rmake)
• rust-lang#125383 (Rewrite emit, mixing-formats and bare-outfile run-make tests in rmake.rs format)
• rust-lang#125401 (Migrate run-make/rustdoc-scrape-examples-macros to rmake.rs)
• rust-lang#125409 (Rename FrameworkOnlyWindows to RawDylibOnlyWindows)
• rust-lang#125416 (Use correct param-env in MissingCopyImplementations)
• rust-lang#125421 (Rewrite core-no-oom-handling, issue-24445 and issue-38237 run-make tests to new rmake.rs format)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 23, 2024

Cleanup: Fix up some diagnostics

Several diagnostics contained their error code inside their primary message which is no bueno. This PR moves them out of the message and turns them into structured error codes.

Also fixes another occurrence of -> after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in rust-lang#104345 (2022) but didn't update all instances as I've noted here: rust-lang#104345 (comment) (“the future is now!”).

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#125210 (Cleanup: Fix up some diagnostics)
• rust-lang#125224 (Migrate run-make/issue-53964 to rmake)
• rust-lang#125227 (Migrate run-make/issue-30063 to rmake)
• rust-lang#125383 (Rewrite emit, mixing-formats and bare-outfile run-make tests in rmake.rs format)
• rust-lang#125401 (Migrate run-make/rustdoc-scrape-examples-macros to rmake.rs)
• rust-lang#125409 (Rename FrameworkOnlyWindows to RawDylibOnlyWindows)
• rust-lang#125416 (Use correct param-env in MissingCopyImplementations)
• rust-lang#125421 (Rewrite core-no-oom-handling, issue-24445 and issue-38237 run-make tests to new rmake.rs format)
• rust-lang#125438 (Remove unneeded string conversion)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#124297 (Allow coercing functions whose signature differs in opaque types in their defining scope into a shared function pointer type)
• rust-lang#124516 (Allow monomorphization time const eval failures if the cause is a type layout issue)
• rust-lang#124976 (rustc: Use tcx.used_crates(()) more)
• rust-lang#125210 (Cleanup: Fix up some diagnostics)
• rust-lang#125409 (Rename FrameworkOnlyWindows to RawDylibOnlyWindows)
• rust-lang#125416 (Use correct param-env in MissingCopyImplementations)
• rust-lang#125421 (Rewrite core-no-oom-handling, issue-24445 and issue-38237 run-make tests to new rmake.rs format)
• rust-lang#125438 (Remove unneeded string conversion)

r? @ghost @rustbot modify labels: rollup

fmease deleted the fix-up-some-diags branch

May 23, 2024 14:53

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024

Rollup merge of rust-lang#125210 - fmease:fix-up-some-diags, r=davidtwco

Cleanup: Fix up some diagnostics

Several diagnostics contained their error code inside their primary message which is no bueno. This PR moves them out of the message and turns them into structured error codes.

Also fixes another occurrence of -> after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in rust-lang#104345 (2022) but didn't update all instances as I've noted here: rust-lang#104345 (comment) (“the future is now!”).

Labels

C-cleanup

Category: PRs that clean code up or issues documenting cleanup.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.