Use correct param-env in MissingCopyImplementations
by compiler-errors · Pull Request #125416 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses.
fixes #125394
r? @lcnr
rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit 8369dbb has been approved by lcnr
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
fmease added a commit to fmease/rust that referenced this pull request
…copy, r=lcnr
Use correct param-env in MissingCopyImplementations
We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses.
fixes rust-lang#125394
fmease added a commit to fmease/rust that referenced this pull request
…copy, r=lcnr
Use correct param-env in MissingCopyImplementations
We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses.
fixes rust-lang#125394
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#122665 (Add some tests for public-private dependencies.)
- rust-lang#125210 (Cleanup: Fix up some diagnostics)
- rust-lang#125316 (Tweak
Spacing
use) - rust-lang#125401 (Migrate
run-make/rustdoc-scrape-examples-macros
tormake.rs
) - rust-lang#125406 (Directly add extension instead of using
Path::with_extension
) - rust-lang#125409 (Rename
FrameworkOnlyWindows
toRawDylibOnlyWindows
) - rust-lang#125416 (Use correct param-env in
MissingCopyImplementations
)
r? @ghost
@rustbot
modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#122665 (Add some tests for public-private dependencies.)
- rust-lang#125210 (Cleanup: Fix up some diagnostics)
- rust-lang#125316 (Tweak
Spacing
use) - rust-lang#125401 (Migrate
run-make/rustdoc-scrape-examples-macros
tormake.rs
) - rust-lang#125406 (Directly add extension instead of using
Path::with_extension
) - rust-lang#125409 (Rename
FrameworkOnlyWindows
toRawDylibOnlyWindows
) - rust-lang#125416 (Use correct param-env in
MissingCopyImplementations
)
r? @ghost
@rustbot
modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…copy, r=lcnr
Use correct param-env in MissingCopyImplementations
We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses.
fixes rust-lang#125394
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#125165 (Migrate
run-make/pgo-branch-weights
tormake
) - rust-lang#125210 (Cleanup: Fix up some diagnostics)
- rust-lang#125224 (Migrate
run-make/issue-53964
tormake
) - rust-lang#125227 (Migrate
run-make/issue-30063
tormake
) - rust-lang#125383 (Rewrite
emit
,mixing-formats
andbare-outfile
run-make
tests inrmake.rs
format) - rust-lang#125401 (Migrate
run-make/rustdoc-scrape-examples-macros
tormake.rs
) - rust-lang#125409 (Rename
FrameworkOnlyWindows
toRawDylibOnlyWindows
) - rust-lang#125416 (Use correct param-env in
MissingCopyImplementations
) - rust-lang#125421 (Rewrite
core-no-oom-handling
,issue-24445
andissue-38237
run-make
tests to newrmake.rs
format)
r? @ghost
@rustbot
modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…copy, r=lcnr
Use correct param-env in MissingCopyImplementations
We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses.
fixes rust-lang#125394
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#125210 (Cleanup: Fix up some diagnostics)
- rust-lang#125224 (Migrate
run-make/issue-53964
tormake
) - rust-lang#125227 (Migrate
run-make/issue-30063
tormake
) - rust-lang#125383 (Rewrite
emit
,mixing-formats
andbare-outfile
run-make
tests inrmake.rs
format) - rust-lang#125401 (Migrate
run-make/rustdoc-scrape-examples-macros
tormake.rs
) - rust-lang#125409 (Rename
FrameworkOnlyWindows
toRawDylibOnlyWindows
) - rust-lang#125416 (Use correct param-env in
MissingCopyImplementations
) - rust-lang#125421 (Rewrite
core-no-oom-handling
,issue-24445
andissue-38237
run-make
tests to newrmake.rs
format) - rust-lang#125438 (Remove unneeded string conversion)
r? @ghost
@rustbot
modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#124297 (Allow coercing functions whose signature differs in opaque types in their defining scope into a shared function pointer type)
- rust-lang#124516 (Allow monomorphization time const eval failures if the cause is a type layout issue)
- rust-lang#124976 (rustc: Use
tcx.used_crates(())
more) - rust-lang#125210 (Cleanup: Fix up some diagnostics)
- rust-lang#125409 (Rename
FrameworkOnlyWindows
toRawDylibOnlyWindows
) - rust-lang#125416 (Use correct param-env in
MissingCopyImplementations
) - rust-lang#125421 (Rewrite
core-no-oom-handling
,issue-24445
andissue-38237
run-make
tests to newrmake.rs
format) - rust-lang#125438 (Remove unneeded string conversion)
r? @ghost
@rustbot
modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#125416 - compiler-errors:param-env-missing-copy, r=lcnr
Use correct param-env in MissingCopyImplementations
We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses.
fixes rust-lang#125394
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.