Migrate run-make/issue-30063 to rmake by Oneirical · Pull Request #125227 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation20 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Part of #121876 and the associated Google Summer of Code project.
(Sorry about the inconvenience of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.)
The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Some changes occurred in run-make tests.
cc @jieyouxu
This comment has been minimized.
This comment has been minimized.
| // This test tries to reproduce this issue with varied emit flags - if it passes, the codegen-units |
|---|
| // are being appropriately reset to 1 after each pass. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, this isn't actually being checked. We're just checking here that foo.rs "compiles with various cli flags", am I understanding that correctly?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in, the original test also isn't checking what this comment is saying?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I wrongfully assumed. The test is checking that the fix did not break compilation, not that the fix itself is doing what it is supposed to do (preventing the annoying re-compilation).
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…jieyouxu
Migrate run-make/issue64319 to rmake and rename
Part of rust-lang#121876 and the associated Google Summer of Code project.
I noticed that the Makefile was not listed in EDIT: No, it was there, just not in its expected alphabetical order.allowed-run-makefiles in Tidy. Does this mean the test was being ignored?
EDIT2: Perhaps it could be interesting to clean this test visually by looping over the rustc calls, like in rust-lang#125227.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#125215 - Oneirical:easy-test-the-second, r=jieyouxu
Migrate run-make/issue64319 to rmake and rename
Part of rust-lang#121876 and the associated Google Summer of Code project.
I noticed that the Makefile was not listed in EDIT: No, it was there, just not in its expected alphabetical order.allowed-run-makefiles in Tidy. Does this mean the test was being ignored?
EDIT2: Perhaps it could be interesting to clean this test visually by looping over the rustc calls, like in rust-lang#125227.
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Thanks, r=me after squashing commits into one.
@bors delegate+
✌️ @Oneirical, you can now approve this pull request!
If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu
📌 Commit f377ea1 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#125165 (Migrate
run-make/pgo-branch-weightstormake) - rust-lang#125210 (Cleanup: Fix up some diagnostics)
- rust-lang#125224 (Migrate
run-make/issue-53964tormake) - rust-lang#125227 (Migrate
run-make/issue-30063tormake) - rust-lang#125383 (Rewrite
emit,mixing-formatsandbare-outfilerun-maketests inrmake.rsformat) - rust-lang#125401 (Migrate
run-make/rustdoc-scrape-examples-macrostormake.rs) - rust-lang#125409 (Rename
FrameworkOnlyWindowstoRawDylibOnlyWindows) - rust-lang#125416 (Use correct param-env in
MissingCopyImplementations) - rust-lang#125421 (Rewrite
core-no-oom-handling,issue-24445andissue-38237run-maketests to newrmake.rsformat)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#125210 (Cleanup: Fix up some diagnostics)
- rust-lang#125224 (Migrate
run-make/issue-53964tormake) - rust-lang#125227 (Migrate
run-make/issue-30063tormake) - rust-lang#125383 (Rewrite
emit,mixing-formatsandbare-outfilerun-maketests inrmake.rsformat) - rust-lang#125401 (Migrate
run-make/rustdoc-scrape-examples-macrostormake.rs) - rust-lang#125409 (Rename
FrameworkOnlyWindowstoRawDylibOnlyWindows) - rust-lang#125416 (Use correct param-env in
MissingCopyImplementations) - rust-lang#125421 (Rewrite
core-no-oom-handling,issue-24445andissue-38237run-maketests to newrmake.rsformat) - rust-lang#125438 (Remove unneeded string conversion)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#122382 (Detect unused structs which implement private traits)
- rust-lang#124389 (Add a warning to proc_macro::Delimiter::None that rustc currently does not respect it.)
- rust-lang#125224 (Migrate
run-make/issue-53964tormake) - rust-lang#125227 (Migrate
run-make/issue-30063tormake) - rust-lang#125336 (Add dedicated definition for intrinsics)
- rust-lang#125401 (Migrate
run-make/rustdoc-scrape-examples-macrostormake.rs) - rust-lang#125454 (Improve the doc of query associated_item)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)