Walk into alias-eq nested goals even if normalization fails by compiler-errors · Pull Request #125688 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Somewhat broken due to the fact that we don't handle aliases well, nor do we handle ambiguities well. Still want to put up this incremental piece, since it improves type errors for projections whose trait refs are not satisfied.

r? lcnr

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so dumb -- this doesn't actually even test that this PR does anything :(

The error comes from i32: Trait WF obligation from <i32 as Trait>::Assoc.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test also doesn't enable -Znext-solver

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 29, 2024

Contributor

lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after either removing or fixing the added test

would like another look at this

@rustbot ready

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 12, 2024

@bors r+ rollup (new solver)

📌 Commit 158536b has been approved by lcnr

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 12, 2024

Blessed once again

@bors r=lcnr

📌 Commit 16892cf has been approved by lcnr

It is now in the queue for this repository.

This comment has been minimized.

📌 Commit 44040a0 has been approved by lcnr

It is now in the queue for this repository.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jun 13, 2024

…=lcnr

Walk into alias-eq nested goals even if normalization fails

Somewhat broken due to the fact that we don't handle aliases well, nor do we handle ambiguities well. Still want to put up this incremental piece, since it improves type errors for projections whose trait refs are not satisfied.

r? lcnr

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 13, 2024

…=lcnr

Walk into alias-eq nested goals even if normalization fails

Somewhat broken due to the fact that we don't handle aliases well, nor do we handle ambiguities well. Still want to put up this incremental piece, since it improves type errors for projections whose trait refs are not satisfied.

r? lcnr

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

…kingjubilee

Rollup of 11 pull requests

Successful merges:

• rust-lang#125165 (Migrate run-make/pgo-branch-weights to rmake)
• rust-lang#125674 (Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format)
• rust-lang#125688 (Walk into alias-eq nested goals even if normalization fails)
• rust-lang#126142 (Harmonize using root or leaf obligation in trait error reporting)
• rust-lang#126303 (Urls to docs in rust_hir)
• rust-lang#126328 (Add Option::is_none_or)
• rust-lang#126337 (Add test for walking order dependent opaque type behaviour)
• rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.)
• rust-lang#126353 (Move MatchAgainstFreshVars to old solver)
• rust-lang#126356 (docs(rustc): Improve discoverable of Cargo docs)
• rust-lang#126362 (Make try_from_target_usize method public)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

…kingjubilee

Rollup of 10 pull requests

Successful merges:

• rust-lang#125674 (Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format)
• rust-lang#125688 (Walk into alias-eq nested goals even if normalization fails)
• rust-lang#126142 (Harmonize using root or leaf obligation in trait error reporting)
• rust-lang#126303 (Urls to docs in rust_hir)
• rust-lang#126328 (Add Option::is_none_or)
• rust-lang#126337 (Add test for walking order dependent opaque type behaviour)
• rust-lang#126353 (Move MatchAgainstFreshVars to old solver)
• rust-lang#126356 (docs(rustc): Improve discoverable of Cargo docs)
• rust-lang#126358 (safe transmute: support Single enums)
• rust-lang#126362 (Make try_from_target_usize method public)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

Rollup merge of rust-lang#125688 - compiler-errors:alias-reporting, r=lcnr

Walk into alias-eq nested goals even if normalization fails

Somewhat broken due to the fact that we don't handle aliases well, nor do we handle ambiguities well. Still want to put up this incremental piece, since it improves type errors for projections whose trait refs are not satisfied.

r? lcnr

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

WG-trait-system-refactor

The Rustc Trait System Refactor Initiative (-Znext-solver)