Urls to docs in rust_hir by sancho20021 · Pull Request #126303 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash this into one commit as well.

I also wonder if we should move this comment to ItemKind and ExprKind. Also it may be useful to note that the reference does not document nightly-only features, and that there may be slight differences in the names and representation of AST nodes between the compiler and the reference.

@@ -1632,6 +1632,10 @@ pub struct ConstBlock {
}

/// An expression.
///
/// For more details, see the [rust lang reference]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// For more details, see the [rust lang reference]
/// For more details, see the [rust lang reference].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -3146,6 +3150,10 @@ impl ItemId {
/// An item
///
/// The name might be a dummy name in case of anonymous items
///
/// For more details, see the [rust lang reference]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// For more details, see the [rust lang reference]
/// For more details, see the [rust lang reference].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

I also wonder if we should move this comment to ItemKind and ExprKind.

Maybe, but I see Item and Expr as the main entities which the developer operates with in many functions. Just less clicks to find the reference.

Also it may be useful to note that the reference does not document nightly-only features, and that there may be slight differences in the names and representation of AST nodes between the compiler and the reference.

Left a note

📌 Commit d1fa19c has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

…rors

Urls to docs in rust_hir

bors added a commit to rust-lang-ci/rust that referenced this pull request

…kingjubilee

Rollup of 11 pull requests

Successful merges:

rust-lang#125165 (Migrate run-make/pgo-branch-weights to rmake)
rust-lang#125674 (Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format)
rust-lang#125688 (Walk into alias-eq nested goals even if normalization fails)
rust-lang#126142 (Harmonize using root or leaf obligation in trait error reporting)
rust-lang#126303 (Urls to docs in rust_hir)
rust-lang#126328 (Add Option::is_none_or)
rust-lang#126337 (Add test for walking order dependent opaque type behaviour)
rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.)
rust-lang#126353 (Move MatchAgainstFreshVars to old solver)
rust-lang#126356 (docs(rustc): Improve discoverable of Cargo docs)
rust-lang#126362 (Make try_from_target_usize method public)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

…kingjubilee

Rollup of 10 pull requests

Successful merges:

rust-lang#125674 (Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format)
rust-lang#125688 (Walk into alias-eq nested goals even if normalization fails)
rust-lang#126142 (Harmonize using root or leaf obligation in trait error reporting)
rust-lang#126303 (Urls to docs in rust_hir)
rust-lang#126328 (Add Option::is_none_or)
rust-lang#126337 (Add test for walking order dependent opaque type behaviour)
rust-lang#126353 (Move MatchAgainstFreshVars to old solver)
rust-lang#126356 (docs(rustc): Improve discoverable of Cargo docs)
rust-lang#126358 (safe transmute: support Single enums)
rust-lang#126362 (Make try_from_target_usize method public)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Rollup merge of rust-lang#126303 - sancho20021:patch-1, r=compiler-errors

Urls to docs in rust_hir

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Relevant to the compiler team, which will review and decide on the PR/issue.