Ignore allocation bytes in some mir-opt tests by cuviper · Pull Request #126502 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This adds rustc -Zdump-mir-exclude-alloc-bytes to skip writing allocation bytes in MIR dumps, and applies it to tests that were failing on s390x due to its big-endian byte order.

Fixes #126261

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 14, 2024

There are additional mir-opt tests that currently use ignore-endian-big to avoid these failures, but I have not yet evaluated whether they would also be solved by this option. We might even want to set this for all mir-opt tests by default, like we do with -Zdump-mir-exclude-pass-number already.

If any tests really should care about the bytes, they can also flip this exclusion off and either ignore or deal with endian differences.

Thanks @cuviper for looking into this! I've just verified that this PR does indeed resolve all mir-opt test failures on s390x.

📌 Commit 7c3673f has been approved by estebank

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 12, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 12, 2024

…es, r=estebank

Ignore allocation bytes in some mir-opt tests

This adds rustc -Zdump-mir-exclude-alloc-bytes to skip writing allocation bytes in MIR dumps, and applies it to tests that were failing on s390x due to its big-endian byte order.

Fixes rust-lang#126261

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 12, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 12, 2024

…kingjubilee

Rollup of 11 pull requests

Successful merges:

• rust-lang#126502 (Ignore allocation bytes in some mir-opt tests)
• rust-lang#126922 (add lint for inline asm labels that look like binary)
• rust-lang#127209 (Added the xop target-feature and the xop_target_feature feature gate)
• rust-lang#127310 (Fix import suggestion ice)
• rust-lang#127338 (Migrate extra-filename-with-temp-outputs and issue-85019-moved-src-dir run-make tests to rmake)
• rust-lang#127381 (Migrate issue-83045, rustc-macro-dep-files and env-dep-info run-make tests to rmake)
• rust-lang#127535 (Fire unsafe_code lint on unsafe extern blocks)
• rust-lang#127619 (Suggest using precise capturing for hidden type that captures region)
• rust-lang#127631 (Remove fully_normalize)
• rust-lang#127632 (Implement precise_capturing support for rustdoc)
• rust-lang#127660 (Rename the internal const_strlen to just strlen)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jul 13, 2024

Rollup merge of rust-lang#126502 - cuviper:dump-mir-exclude-alloc-bytes, r=estebank

Ignore allocation bytes in some mir-opt tests

This adds rustc -Zdump-mir-exclude-alloc-bytes to skip writing allocation bytes in MIR dumps, and applies it to tests that were failing on s390x due to its big-endian byte order.

Fixes rust-lang#126261

uweigand added a commit to uweigand/rust that referenced this pull request

Jul 15, 2024

Following on PR rust-lang#126502, add rustc -Zdump-mir-exclude-alloc-bytes to tests/mir-opt/dataflow-const-prop/aggregate_copy.rs as well to skip writing allocation bytes in MIR dumps.

Fixes rust-lang#126261

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 20, 2024

…rk-Simulacrum

Ignore allocation bytes in one more mir-opt test

Following on PR rust-lang#126502, add rustc -Zdump-mir-exclude-alloc-bytes to tests/mir-opt/dataflow-const-prop/aggregate_copy.rs as well to skip writing allocation bytes in MIR dumps.

Fixes rust-lang#126261

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jul 21, 2024

Rollup merge of rust-lang#127752 - uweigand:s390x-miropt-update, r=Mark-Simulacrum

Ignore allocation bytes in one more mir-opt test

Following on PR rust-lang#126502, add rustc -Zdump-mir-exclude-alloc-bytes to tests/mir-opt/dataflow-const-prop/aggregate_copy.rs as well to skip writing allocation bytes in MIR dumps.

Fixes rust-lang#126261

cuviper deleted the dump-mir-exclude-alloc-bytes branch

September 4, 2024 23:43

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.