Migrate issue-83045, rustc-macro-dep-files and env-dep-info run-make tests to rmake by Oneirical · Pull Request #127381 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation28 Commits3 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
The run-make-support library was changed
cc @jieyouxu
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
This comment has been minimized.
@bors delegate+ (for try jobs)
✌️ @Oneirical, you can now approve this pull request!
If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
☀️ Try build successful - checks-actions
Build commit: 90002cd (90002cddaba1d3610bfa936fd7568afde536568f)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, the tests look good in general, I left some suggestions and some questions/discussions.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, the tests look good, just minor doc adjustment requests ^^
Comment on lines 14 to 16
| /// Construct a plain `rustc` invocation with no flags set. Note that compiletest |
|---|
| /// still presets the environment variables `HOST_RPATH_DIR` and `TARGET_RPATH_DIR` |
| /// by default. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: sorry I should've been more clear. What I meant was moreso set_common calls set_host_rpath, not the one in compiletest:
| /// Set the runtime library path as needed for running the host rustc/rustdoc/etc. |
|---|
| pub fn set_host_rpath(cmd: &mut Command) { |
| let ld_lib_path_envvar = env_var("LD_LIB_PATH_ENVVAR"); |
| cmd.env(&ld_lib_path_envvar, { |
| let mut paths = vec![]; |
| paths.push(cwd()); |
| paths.push(PathBuf::from(env_var("HOST_RPATH_DIR"))); |
| for p in env::split_paths(&env_var(&ld_lib_path_envvar)) { |
| paths.push(p.to_path_buf()); |
| } |
| env::join_paths(paths.iter()).unwrap() |
| }); |
| } |
r=me with a rebase + addressing the doc comment.
@rustbot author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
📌 Commit fe76650 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 11 pull requests
Successful merges:
- rust-lang#126502 (Ignore allocation bytes in some mir-opt tests)
- rust-lang#126922 (add lint for inline asm labels that look like binary)
- rust-lang#127209 (Added the
xoptarget-feature and thexop_target_featurefeature gate) - rust-lang#127310 (Fix import suggestion ice)
- rust-lang#127338 (Migrate
extra-filename-with-temp-outputsandissue-85019-moved-src-dirrun-maketests to rmake) - rust-lang#127381 (Migrate
issue-83045,rustc-macro-dep-filesandenv-dep-inforun-maketests to rmake) - rust-lang#127535 (Fire unsafe_code lint on unsafe extern blocks)
- rust-lang#127619 (Suggest using precise capturing for hidden type that captures region)
- rust-lang#127631 (Remove
fully_normalize) - rust-lang#127632 (Implement
precise_capturingsupport for rustdoc) - rust-lang#127660 (Rename the internal
const_strlento juststrlen)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)