Rename the internal const_strlen to just strlen by tgross35 · Pull Request #127660 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Since the libs and lang teams completed an FCP to allow for const strlen (1), currently implemented with const_eval_select, there is no longer any reason to avoid this specific function or use it only in const.
Rename it to reflect this status change.
Discussed at #127433 (comment) / #127444 (comment)
r? @dtolnay
Since the libs and lang teams completed an FCP to allow for const
strlen ([1]), currently implemented with const_eval_select, there is
no longer any reason to avoid this specific function or use it only in
const.
Rename it to reflect this status change.
[1]: rust-lang#113219 (comment)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
📌 Commit 2772f89 has been approved by dtolnay
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 11 pull requests
Successful merges:
- rust-lang#126502 (Ignore allocation bytes in some mir-opt tests)
- rust-lang#126922 (add lint for inline asm labels that look like binary)
- rust-lang#127209 (Added the
xoptarget-feature and thexop_target_featurefeature gate) - rust-lang#127310 (Fix import suggestion ice)
- rust-lang#127338 (Migrate
extra-filename-with-temp-outputsandissue-85019-moved-src-dirrun-maketests to rmake) - rust-lang#127381 (Migrate
issue-83045,rustc-macro-dep-filesandenv-dep-inforun-maketests to rmake) - rust-lang#127535 (Fire unsafe_code lint on unsafe extern blocks)
- rust-lang#127619 (Suggest using precise capturing for hidden type that captures region)
- rust-lang#127631 (Remove
fully_normalize) - rust-lang#127632 (Implement
precise_capturingsupport for rustdoc) - rust-lang#127660 (Rename the internal
const_strlento juststrlen)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#127660 - tgross35:const_strlen-rename, r=dtolnay
Rename the internal const_strlen to just strlen
Since the libs and lang teams completed an FCP to allow for const strlen ([1]), currently implemented with const_eval_select, there is no longer any reason to avoid this specific function or use it only in const.
Rename it to reflect this status change.
[1]: rust-lang#113219 (comment)
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.