Rename a bunch of things in the new solver and rustc_type_ir by compiler-errors · Pull Request #126650 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

• Renames interner() to cx() in the solver and TypeFolder.
• Renames Infcx generic param to D
• Moves infcx.rs to delegate.rs

r? lcnr

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in abstract_const.rs

cc @BoxyUwU

a lot nicer

@bors r+ rollup=iffy

📌 Commit ec88615 has been approved by lcnr

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 19, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

Rename a bunch of things in the new solver and rustc_type_ir

• Renames interner() to cx() in the solver and TypeFolder.
• Renames Infcx generic param to D
• Moves infcx.rs to delegate.rs

r? lcnr

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

Rollup of 7 pull requests

Successful merges:

• rust-lang#124807 (Migrate run-make/rustdoc-io-error to rmake.rs)
• rust-lang#126095 (Migrate link-args-order, ls-metadata and lto-readonly-lib run-make tests to rmake)
• rust-lang#126308 (Ban ArrayToPointer and MutToConstPointer from runtime MIR)
• rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted)
• rust-lang#126629 (Migrate run-make/compressed-debuginfo to rmake.rs)
• rust-lang#126644 (Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake)
• rust-lang#126650 (Rename a bunch of things in the new solver and rustc_type_ir)

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

Rename a bunch of things in the new solver and rustc_type_ir

• Renames interner() to cx() in the solver and TypeFolder.
• Renames Infcx generic param to D
• Moves infcx.rs to delegate.rs

r? lcnr

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

Rename a bunch of things in the new solver and rustc_type_ir

• Renames interner() to cx() in the solver and TypeFolder.
• Renames Infcx generic param to D
• Moves infcx.rs to delegate.rs

r? lcnr

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2024

Rollup of 9 pull requests

Successful merges:

• rust-lang#126095 (Migrate link-args-order, ls-metadata and lto-readonly-lib run-make tests to rmake)
• rust-lang#126534 (Migrate run-make/comment-section to rmake.rs)
• rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted)
• rust-lang#126629 (Migrate run-make/compressed-debuginfo to rmake.rs)
• rust-lang#126644 (Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake)
• rust-lang#126650 (Rename a bunch of things in the new solver and rustc_type_ir)
• rust-lang#126698 (Migrate unknown-mod-stdin, issue-68794-textrel-on-minimal-lib, raw-dylib-cross-compilation and used-cdylib-macos run-make tests to rmake)
• rust-lang#126703 (reword the hint::blackbox non-guarantees)
• rust-lang#126708 (Minimize can_begin_literal_maybe_minus usage)

r? @ghost @rustbot modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jun 20, 2024

📌 Commit db638ab has been approved by lcnr

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 21, 2024

bors mentioned this pull request

Jun 21, 2024

Finished benchmarking commit (c1b336c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 694.66s -> 697.477s (0.41%)
Artifact size: 326.79 MiB -> 326.87 MiB (0.03%)