Migrate link-args-order, ls-metadata and lto-readonly-lib run-make tests to rmake by Oneirical · Pull Request #126095 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation46 Commits4 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Some changes occurred in run-make tests.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

rustbot added A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jun 6, 2024

rustbot added S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 6, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Making a note for myself:

Test stderr: The stderr "error: linking with ld failed: exit status: 1 [...] "-z" "now" "a" "\"b" "c\"" "\"d" "e\"" "f"

Test fail message: " did not contain the string ""a" "b" "c" "d" "e" "f""

Strange error... the stderr being printed out in the test failure log is the correct one, but the one being checked by assert_stderr_contains is nothing but a single double-quote.

I added lld-link if Windows is detected, giving it another @bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

This comment has been minimized.

I restored the ignore-msvc as it's still running into issues with the llvm linker. Let me know if you think I should try with another different linker.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think it's fine to keep it ld only for now.

@bors r+

📌 Commit b3c5132 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 19, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

Rollup of 7 pull requests

Successful merges:

• rust-lang#124807 (Migrate run-make/rustdoc-io-error to rmake.rs)
• rust-lang#126095 (Migrate link-args-order, ls-metadata and lto-readonly-lib run-make tests to rmake)
• rust-lang#126308 (Ban ArrayToPointer and MutToConstPointer from runtime MIR)
• rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted)
• rust-lang#126629 (Migrate run-make/compressed-debuginfo to rmake.rs)
• rust-lang#126644 (Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake)
• rust-lang#126650 (Rename a bunch of things in the new solver and rustc_type_ir)

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2024

Rollup of 9 pull requests

Successful merges:

• rust-lang#126095 (Migrate link-args-order, ls-metadata and lto-readonly-lib run-make tests to rmake)
• rust-lang#126534 (Migrate run-make/comment-section to rmake.rs)
• rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted)
• rust-lang#126629 (Migrate run-make/compressed-debuginfo to rmake.rs)
• rust-lang#126644 (Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake)
• rust-lang#126650 (Rename a bunch of things in the new solver and rustc_type_ir)
• rust-lang#126698 (Migrate unknown-mod-stdin, issue-68794-textrel-on-minimal-lib, raw-dylib-cross-compilation and used-cdylib-macos run-make tests to rmake)
• rust-lang#126703 (reword the hint::blackbox non-guarantees)
• rust-lang#126708 (Minimize can_begin_literal_maybe_minus usage)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

• rust-lang#126095 (Migrate link-args-order, ls-metadata and lto-readonly-lib run-make tests to rmake)
• rust-lang#126629 (Migrate run-make/compressed-debuginfo to rmake.rs)
• rust-lang#126644 (Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake)
• rust-lang#126735 (collect attrs in const block expr)
• rust-lang#126737 (Remove feature(const_closures) from libcore)
• rust-lang#126740 (add needs-unwind to UI test)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2024

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)