Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake by Oneirical · Pull Request #126644 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation26 Commits5 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Oneirical

@rustbot

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jun 18, 2024

@rustbot

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@jieyouxu

@bors delegate+ (for try job, don't r+ yet)

@bors

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@Oneirical

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

@bors

@bors

@bors

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 19, 2024

@rust-log-analyzer

This comment has been minimized.

@jieyouxu

@Oneirical

Did you r- by muscle memory? Hehe

So, it seems like this forced-unwind-terminate-pof test uses pthread, a POSIX exclusive. I nerfed the ignore down from only-linux to ignore-windows, as it should work on MacOS/BSD too.

@Oneirical

@rustbot review

I'm quite confident about this working on OSX, but I added the try job in case you want to make sure before putting this through the full CI.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 19, 2024

@jieyouxu

Did you r- by muscle memory? Hehe

Sorry, I was doing rollups at the time and was doing r- for a couple of different PRs and saw test failed in this PR lol

@jieyouxu

Yes, tests look good but let's run a try job to double check

@bors try

@jieyouxu

r=me if the try job comes back green

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

@bors

@bors

☀️ Try build successful - checks-actions
Build commit: a8c593c (a8c593c062e992c338e6d015c53d32d745e15dd2)

@Oneirical

@bors

📌 Commit 2eab81a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 19, 2024

jieyouxu

Comment on lines 14 to 18

rustc()
.input("bar.rs")
.extern_("foo1", rust_lib_name("foo-a"))
.extern_("foo2", rust_lib_name("foo-b"))
.print("link-args")
.run();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is this supposed to be checking output of --print=link-args? I know the original test does the same thing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, if it should be run_unchecked? I don't see why, if the original test worked on all platforms as run, why would we need to reduce the exactitude of the test by not checking?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I mean that this invocation uses --print=link-args but we're not checking what stdout contains (or what the content of --print=link-args is), is that intentional?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is quite weird indeed, my guess is that the test writer left it in as a way to debug their own test if it failed. The test works locally without it, so I am removing it now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me when CI passes

@jieyouxu

@bors r- (sorry i just noticed this)

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jun 19, 2024

@Oneirical

@Oneirical

@bors

📌 Commit e7ea063 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 19, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 19, 2024

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

@jieyouxu

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Jun 19, 2024

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2024

@bors

Rollup of 9 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2024

@bors

…iaskrgr

Rollup of 6 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 20, 2024

@rust-timer

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)