add needs-unwind to UI test by japaric · Pull Request #126740 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
the tail-expr-lock-poisoning UI test uses the panic::catch_unwind API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the needs-unwind attribute to signal this
the tail-expr-lock-poisoning UI test uses the panic::catch_unwind
API so it relies on unwinding being implemented. this test ought not to
run on targets that do not support unwinding. add the needs-unwind
attribute to signal this
r? @lcnr
rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit f42fa4f has been approved by lcnr
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
| @@ -3,6 +3,7 @@ |
|---|
| //@ [edition2024] compile-flags: -Zunstable-options |
| //@ [edition2024] edition: 2024 |
| //@ run-pass |
| //@ needs-unwind |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove the //@ ignore-wasm that test directive is only used here due to wasm not supporting panic=unwind.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#126095 (Migrate
link-args-order,ls-metadataandlto-readonly-librun-maketests tormake) - rust-lang#126629 (Migrate
run-make/compressed-debuginfotormake.rs) - rust-lang#126644 (Rewrite
extern-flag-rename-transitive.debugger-visualizer-dep-info,metadata-flag-frobs-symbols,extern-overrides-distributionandforced-unwind-terminate-pofrun-maketests to rmake) - rust-lang#126735 (collect attrs in const block expr)
- rust-lang#126737 (Remove
feature(const_closures)from libcore) - rust-lang#126740 (add
needs-unwindto UI test)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#126740 - ferrocene:ja-ui-test-needs-unwind, r=lcnr
add needs-unwind to UI test
the tail-expr-lock-poisoning UI test uses the panic::catch_unwind API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the needs-unwind attribute to signal this
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.