Migrate macos-fat-archive, manual-link and archive-duplicate-names run-make tests to rmake by Oneirical · Pull Request #127825 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation19 Commits3 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
The run-make-support library was changed
cc @jieyouxu
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
☀️ Try build successful - checks-actions
Build commit: 89137b1 (89137b1a6bf921962101fc4e5ca80885d76f0821)
Question: is build_native_static_lib conflicting with any other PR (I think it does?), and if so, should this be blocked on some PR that first introduces the helper?
Question: is
build_native_static_libconflicting with any other PR (I think it does?), and if so, should this be blocked on some PR that first introduces the helper?
Not anymore since #126208 got merged. I still shuffle lib.rs around a bit so that the shallow_find_files companion functions are all nicely packed together.
Not anymore since #126208 got merged. I still shuffle
lib.rsaround a bit so that theshallow_find_filescompanion functions are all nicely packed together.
Er, do you mind waiting for #127760 which will... shuffle lib.rs quite a bit?
Status: Blocked on something else such as an RFC or other implementation work.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
@rustbot review (unblocked, ill take a look soon)
Status: Awaiting review from the assignee but also interested parties.
and removed S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
labels
This comment has been minimized.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changes look reasonable to me.
@bors r+ rollup=iffy (building c, llvm-ar usage)
📌 Commit 53f61e1 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 47c2101 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#121533 (Handle .init_array link_section specially on wasm)
- rust-lang#127825 (Migrate
macos-fat-archive,manual-linkandarchive-duplicate-namesrun-maketests to rmake) - rust-lang#127891 (Tweak suggestions when using incorrect type of enum literal)
- rust-lang#127902 (
collect_tokens_trailing_tokencleanups) - rust-lang#127928 (Migrate
lto-smoke-candlink-path-orderrun-maketests to rmake) - rust-lang#127935 (Change
binary_asm_labelsto only fire on x86 and x86_64) - rust-lang#127953 ([compiletest] Search *.a when getting dynamic libraries on AIX)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)